Make sure npm test script gets run on AppVeyor #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astorije
added
Type: Feature
|
npm test doesn't return the exit code, so we won't know if it fails on appveyor without opening the page and looking at the log. |
|
Yes, but that's OK, because the 3 statements after would catch that. That first line is to make sure we never break |
|
Fine by me, even if kind of ugly. At least until we move this into a real script instead. |
matburnham
pushed a commit
to matburnham/lounge
that referenced
this pull request
Sep 6, 2017
…veyor Make sure npm test script gets run on AppVeyor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yes, this duplicates tests, but the whole point (at least for now) of AppVeyor for us is to make sure we do not break the dev environment,
npm install,npm run buildandnpm test.The source of truth is still Travis CI, so if the output on AppVeyor is less digestible, it's not too much of a big deal.
In terms of speed,
npm testis a few seconds long, very much negligible compared to the 5-to-15-minute latency it takes for AppVeyor to wake up.