Don't send completely empty messages #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxpoulin64
added
Type: Bug
|
Good catch, nice simple fix. Merging because small bug, and causing people issues who are on master right now. |
|
👍 |
|
Just for the record: #320 (comment) |
|
@astorije I think we thought that was referring to messages with only spaces (comment) as that's a legitimate message in terms of IRC, but a completely empty one shouldn't be (and would mean you can accidentally just press return twice and accidentally send a message). I think there's a difference there. |
|
I see, sorry I missed that, thanks for the clarification. |
matburnham
pushed a commit
to matburnham/lounge
that referenced
this pull request
Sep 6, 2017
Don't send completely empty messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Little oops due to #320, sending white space is fine but sending completely empty messages isn't. Fixing both on the server and the client to prevent unneeded spamming of the server if something is holding the key and key repeat kicks in.
Bug pointed out by @MaxLeiter on IRC.