Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide options will now remove the row completely #227

Merged
merged 1 commit into from
Mar 30, 2016
Merged

Hide options will now remove the row completely #227

merged 1 commit into from
Mar 30, 2016

Conversation

xPaw
Copy link
Member

@xPaw xPaw commented Mar 30, 2016

Fixes this: https://forum.cozy.io/uploads/default/original/1X/d75836720701429278ddaeebb35ddb3fab7656c4.PNG

1.4.1 uses fixed table layout, so incorrectly hiding rows revealed the bug.

@xPaw xPaw added Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors. second review needed labels Mar 30, 2016
@maxpoulin64 maxpoulin64 self-assigned this Mar 30, 2016
@maxpoulin64
Copy link
Member

👍

@maxpoulin64 maxpoulin64 merged commit e0031dd into master Mar 30, 2016
@maxpoulin64 maxpoulin64 deleted the xpaw/fix-table-layout-when-hiding branch March 30, 2016 19:28
@astorije astorije restored the xpaw/fix-table-layout-when-hiding branch March 31, 2016 02:51
@astorije astorije deleted the xpaw/fix-table-layout-when-hiding branch March 31, 2016 02:51
@maxpoulin64 maxpoulin64 mentioned this pull request Mar 31, 2016
Closed
@xPaw xPaw mentioned this pull request May 15, 2016
Merged
@astorije astorije added this to the 1.4.2 milestone Oct 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@maxpoulin64 maxpoulin64

Labels
Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors.
Projects
None yet
Milestone
1.4.2
Development

Successfully merging this pull request may close these issues.
3 participants
@xPaw @maxpoulin64 @astorije