Make sure self messages are never highlighted

[astorije]

Fixes #156.

[dgw]

I was thinking about this yesterday and didn't get around to making an issue for it, and here's a PR all set to fix it. 👍

[astorije]

This is a quick fix, but maybe a wee bit longer-term solution should be to parse and trigger on the client instead, like #152 is doing, no?

[maxpoulin64]

Wouldn't it be better to check for self before the loop and avoid splitting the message entirely instead of doing it and overriding it right after?

Also, my PR doesn't actually touch that. This function is only responsible of turning IRC messages into HTML. If we want to handle highlights on the client, it would fit more in the msg handler. One minor thing for client-side highlights: if the user changes nicks and reload the page, the previous highlights will no longer be highlighted. Storing it in the server object has the benefit of making it permanent.

[xPaw]

@maxpoulin64 is right, check for self and then avoiding message splitting would be a better way.

[AlMcKinlay]

Does this remove the need for #146 ?

I actually think it's a much nicer way of doing it, rather than hacking in the client as to which highlight messages we actually show.

[xPaw]

Hm, looks like yes, it does.

[AlMcKinlay]

Yeah, that's fine. I think it's better dealing with it this way, especially for this issue.

[astorije]

Good point guys, I'll fix that. Also, I have a decent (well, in my opinion :p) idea how to make these testable, will post here when I get to it. Edit: Not doable at the moment (but that I knew), I'll see in a future PR.

[astorije]

Hi all, took your comments into consideration to make things nicer. Thanks for looking carefully and sorry for being reckless in the first place :p
So now, the highlight lookup is only done if this is not a message from self. Also, I added something else: using some(), I stop the lookup early when one of the words matches. @maxpoulin64, I specifically thought of your addition to performance matters while doing so :D

[maxpoulin64]

👍 looks all good to me