-
Notifications
You must be signed in to change notification settings - Fork 700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use stylelint-config-standard #1249
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not convinced about defining the tab width in the editor config, because that should be up to individuals, not us. All we care about is it being a tab. But if others want it, I don't care massively as the IDE I use lets me override it easily. At least we have tabs ;-)
@@ -1722,10 +1721,7 @@ kbd { | |||
border-right-color: #222; | |||
} | |||
|
|||
@media only screen and (-webkit-min-device-pixel-ratio: 2), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these no longer needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resolution
is the way to do it, min-device-pixel-ratio is deprecated.
.editorconfig
Outdated
@@ -6,6 +6,7 @@ root = true | |||
|
|||
[*] | |||
indent_style = tab | |||
tab_width = 4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Such big tabs. Weird people.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was mainly for github (it uses editor config), and it defaults to 8 tabs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, 4 is definitely better than 8.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not 2
to match L20 and former L24?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, meant to approve there.
5a2fd35
to
138111b
Compare
Removed |
…g-standard Use stylelint-config-standard
We're surprisingly quite standard except for three rules.