Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use stylelint-config-standard #1249

Merged
merged 1 commit into from
Jun 23, 2017
Merged

Conversation

xPaw
Copy link
Member

@xPaw xPaw commented Jun 21, 2017

We're surprisingly quite standard except for three rules.

@xPaw xPaw added the Type: Feature Tickets that describe a desired feature or PRs that add them to the project. label Jun 21, 2017
Copy link
Member

@AlMcKinlay AlMcKinlay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not convinced about defining the tab width in the editor config, because that should be up to individuals, not us. All we care about is it being a tab. But if others want it, I don't care massively as the IDE I use lets me override it easily. At least we have tabs ;-)

@@ -1722,10 +1721,7 @@ kbd {
border-right-color: #222;
}

@media only screen and (-webkit-min-device-pixel-ratio: 2),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these no longer needed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolution is the way to do it, min-device-pixel-ratio is deprecated.

.editorconfig Outdated
@@ -6,6 +6,7 @@ root = true

[*]
indent_style = tab
tab_width = 4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Such big tabs. Weird people.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was mainly for github (it uses editor config), and it defaults to 8 tabs.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, 4 is definitely better than 8.

Copy link
Member

@astorije astorije Jun 22, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not 2 to match L20 and former L24?

Copy link
Member

@AlMcKinlay AlMcKinlay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, meant to approve there.

@xPaw xPaw added this to the 2.3.2 milestone Jun 21, 2017
@xPaw xPaw force-pushed the xpaw/stylelint-config-standard branch from 5a2fd35 to 138111b Compare June 22, 2017 08:27
@xPaw
Copy link
Member Author

xPaw commented Jun 22, 2017

Removed tab-width from this PR.

@astorije astorije merged commit 96e6ac8 into master Jun 23, 2017
@astorije astorije deleted the xpaw/stylelint-config-standard branch June 23, 2017 05:44
matburnham pushed a commit to matburnham/lounge that referenced this pull request Sep 6, 2017
…g-standard

Use stylelint-config-standard
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature Tickets that describe a desired feature or PRs that add them to the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants