Add support for 0x04 hex colors #1100
Conversation
xPaw
added
the
Type: Feature
| @@ -12,6 +13,9 @@ const UNDERLINE = "\x1f"; | |||
| // integers, `XX` is the text color and `YY` is an optional background color. | |||
| const colorRx = /^(\d{1,2})(?:,(\d{1,2}))?/; | |||
|
|
|||
| // 6-char Hex color code matcher | |||
| const hexColorRx = /^([a-fA-F0-6]{6})?/; | |||
There was a problem hiding this comment.
pattern seems wrong, should be /^([0-9a-f]{6})?/i ?
| @@ -104,12 +109,70 @@ describe("parseStyle", () => { | |||
| expect(actual).to.deep.equal(expected); | |||
| }); | |||
|
|
|||
| it("should parse hex colors", () => { | |||
| const input = "test \x04FFFFFFnice \x02\x04RES006 \x0303,04\x04ff00FFcolored"; | |||
There was a problem hiding this comment.
is hex formatting foreground only? (if you have access to the clients, do you mind to verify?)
also more color variation would be nice (see issue with pattern)
There was a problem hiding this comment.
Hmm, AdiIRC seems to allow foreground and background. I should make it more clear on the doc that it allows setting both foreground and background colours with hex in this way
There was a problem hiding this comment.
@xPaw, do you want/need to update your PR to account for foreground/background as per @DanielOaks' comment or not?
There was a problem hiding this comment.
This currently does not support background colors. Considering @DanielOaks didn't know that too, I wonder how many clients implement it, compared to just the foreground color.
There was a problem hiding this comment.
Right, it doesn't. But don't we want to be the first IRC client leading the way forward? :D (Ok ok it's a minor lead 😅)
There was a problem hiding this comment.
Considering there is no formal definition, we want to know how it's already implemented in other clients.
|
Added support for background colors. |
Add support for 0x04 hex colors
Ref: https://modern.ircdocs.horse/formatting.html#hex-color
At least IRCCloud and AdiIRC support it.
cc @Bonuspunkt