Fix /invite command broken by lodash update #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice catch, as invite was added after the lodash PR was created 👍 |
JocelynDelalande
added a commit
that referenced
this pull request
Feb 25, 2016
Fix /invite command broken by lodash update
astorije
added
the
Type: Bug
|
Nice catch! |
That was the only findWhere left in master, and this very line was not in 1.2.1
What tool ? |
|
The one mentioned at #38 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Broken by #38 / 19bc4f3
receiving a
/invitewas crashing shout.