Stick to bottom when opening user list #1032
Conversation
xPaw
added
the
Type: Bug
| @@ -729,6 +729,7 @@ $(function() { | |||
| var self = $(this); | |||
| viewport.toggleClass(self.attr("class")); | |||
| e.stopPropagation(); | |||
| chat.find(".chan.active .chat").trigger("msg.sticky"); | |||
There was a problem hiding this comment.
I was expecting that if I was not stick'ed to bottom and clicked on the user list button this would force-stick me but it doesn't.
It works as expected, i.e. sticks you to bottom only if you were before clicking, but I can't figure out why. Do you happen to know what magic is this, @xPaw? If I read this correctly, any click should stick you to bottom regardless of scroll position before clicking.
There was a problem hiding this comment.
That's the expected behaviour, that event only keeps at the bottom.
There was a problem hiding this comment.
Hmm yes, but that's not what I meant. Probably explained myself poorly.
Let's put it that way: go to a channel, scroll all the way up, then click on the user list button. According to this change, I'm reading that this should force the window to go stickied to bottom, even though you probably don't want that if you weren't at the bottom before clicking. But this behavior doesn't happen, user stays at the top. This is great, you don't want to get moved to bottom if you weren't before, but I don't understand how that's possible.
There was a problem hiding this comment.
Stick to bottom when opening user list
Fixes #1031