Store channel keys #1003
Merged
Store channel keys #1003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xPaw
added
the
Type: Feature
Closed
|
Just like the parser PR, I think the commit author should be @spookhurb :) |
astorije
added
the
Type: Security
|
I didn't re-use his code (besides test), and it uses a different approach. |
astorije
requested changes
Apr 1, 2017
src/plugins/irc-events/mode.js
Outdated
| } | ||
|
|
||
| for (var i = 0; i < data.modes.length; i++) { | ||
| var mode = data.modes[i]; |
There was a problem hiding this comment.
This is a minor nitpick, but any reason why not to use data.modes.forEach(mode => { ... }); instead?
Also, const when possible?
astorije
approved these changes
Apr 1, 2017
matburnham
pushed a commit
to matburnham/lounge
that referenced
this pull request
Sep 6, 2017
Store channel keys
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #412 and supercedes #715. This PR gets channel key from channel mode, instead of hooking join command.
cc @spookhurb, @DanielOaks