From fb4cf6c1a72338fc5a868db2eb60619d1a0ad020 Mon Sep 17 00:00:00 2001 From: Kavin Aravind Date: Wed, 25 May 2022 13:51:30 -0400 Subject: [PATCH 1/3] modified Start process via selector bug --- internal/api/v1beta1/app_types.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/internal/api/v1beta1/app_types.go b/internal/api/v1beta1/app_types.go index 3236c89b..22bd7ba5 100644 --- a/internal/api/v1beta1/app_types.go +++ b/internal/api/v1beta1/app_types.go @@ -425,6 +425,7 @@ func (app *App) Start(selector Selector) error { for i, processSpec := range deploymentSpec.Processes { if processSpec.Name == *selector.Process && (processSpec.Units == nil || *processSpec.Units == 0) { deploymentSpec.Processes[i].Units = &units + deploymentFound = true } } } else { @@ -433,11 +434,11 @@ func (app *App) Start(selector Selector) error { continue } deploymentSpec.Processes[i].Units = &units + deploymentFound = true } } - deploymentFound = true } - if selector.DeploymentVersion != nil && !deploymentFound { + if (selector.DeploymentVersion != nil || selector.Process != nil) && !deploymentFound { return ErrDeploymentNotFound } return nil From b12a7feded8ca7f81f54a644ff0c98a1a00171f1 Mon Sep 17 00:00:00 2001 From: Kavin Aravind Date: Thu, 26 May 2022 18:28:08 -0400 Subject: [PATCH 2/3] fixed typo for app start command --- cmd/ketch/app_start.go | 2 +- coverage.txt | 18 ++++++++++++++++++ 2 files changed, 19 insertions(+), 1 deletion(-) create mode 100644 coverage.txt diff --git a/cmd/ketch/app_start.go b/cmd/ketch/app_start.go index 16cd332c..4a4cd455 100644 --- a/cmd/ketch/app_start.go +++ b/cmd/ketch/app_start.go @@ -56,7 +56,7 @@ func appStart(ctx context.Context, cfg config, options appStartOptions, out io.W } s := ketchv1.NewSelector(options.deploymentVersion, options.processName) if err := app.Start(s); err != nil { - return fmt.Errorf("failed to stop app: %w", err) + return fmt.Errorf("failed to start app: %w", err) } if err := cfg.Client().Update(ctx, &app); err != nil { return fmt.Errorf("failed to update app: %w", err) diff --git a/coverage.txt b/coverage.txt new file mode 100644 index 00000000..5e169903 --- /dev/null +++ b/coverage.txt @@ -0,0 +1,18 @@ +ok github.com/theketchio/ketch/cmd/ketch 8.374s coverage: 61.5% of statements +? github.com/theketchio/ketch/cmd/ketch/configuration [no test files] +ok github.com/theketchio/ketch/cmd/ketch/output 0.105s coverage: 68.3% of statements +? github.com/theketchio/ketch/cmd/manager [no test files] +ok github.com/theketchio/ketch/internal/api/v1beta1 2.467s coverage: 33.3% of statements +? github.com/theketchio/ketch/internal/api/v1beta1/mocks [no test files] +ok github.com/theketchio/ketch/internal/build 0.429s coverage: 92.3% of statements +ok github.com/theketchio/ketch/internal/chart 0.981s coverage: 72.0% of statements +ok github.com/theketchio/ketch/internal/controllers 76.387s coverage: 66.2% of statements +ok github.com/theketchio/ketch/internal/deploy 0.502s coverage: 39.7% of statements +ok github.com/theketchio/ketch/internal/errors 0.118s coverage: 50.0% of statements +? github.com/theketchio/ketch/internal/mocks [no test files] +? github.com/theketchio/ketch/internal/pack [no test files] +ok github.com/theketchio/ketch/internal/templates 0.211s coverage: 5.0% of statements +? github.com/theketchio/ketch/internal/templates/generator [no test files] +? github.com/theketchio/ketch/internal/utils [no test files] +? github.com/theketchio/ketch/internal/utils/conversions [no test files] +? github.com/theketchio/ketch/internal/validation [no test files] From cf87cb7e2112c8770dc291cf58354241352f6788 Mon Sep 17 00:00:00 2001 From: Kavin Aravind Date: Thu, 26 May 2022 18:28:45 -0400 Subject: [PATCH 3/3] Delete coverage.txt --- coverage.txt | 18 ------------------ 1 file changed, 18 deletions(-) delete mode 100644 coverage.txt diff --git a/coverage.txt b/coverage.txt deleted file mode 100644 index 5e169903..00000000 --- a/coverage.txt +++ /dev/null @@ -1,18 +0,0 @@ -ok github.com/theketchio/ketch/cmd/ketch 8.374s coverage: 61.5% of statements -? github.com/theketchio/ketch/cmd/ketch/configuration [no test files] -ok github.com/theketchio/ketch/cmd/ketch/output 0.105s coverage: 68.3% of statements -? github.com/theketchio/ketch/cmd/manager [no test files] -ok github.com/theketchio/ketch/internal/api/v1beta1 2.467s coverage: 33.3% of statements -? github.com/theketchio/ketch/internal/api/v1beta1/mocks [no test files] -ok github.com/theketchio/ketch/internal/build 0.429s coverage: 92.3% of statements -ok github.com/theketchio/ketch/internal/chart 0.981s coverage: 72.0% of statements -ok github.com/theketchio/ketch/internal/controllers 76.387s coverage: 66.2% of statements -ok github.com/theketchio/ketch/internal/deploy 0.502s coverage: 39.7% of statements -ok github.com/theketchio/ketch/internal/errors 0.118s coverage: 50.0% of statements -? github.com/theketchio/ketch/internal/mocks [no test files] -? github.com/theketchio/ketch/internal/pack [no test files] -ok github.com/theketchio/ketch/internal/templates 0.211s coverage: 5.0% of statements -? github.com/theketchio/ketch/internal/templates/generator [no test files] -? github.com/theketchio/ketch/internal/utils [no test files] -? github.com/theketchio/ketch/internal/utils/conversions [no test files] -? github.com/theketchio/ketch/internal/validation [no test files]