Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed #5793: fixed the alignment in search-in-workspace result node #5802

Merged
merged 1 commit into from
Jul 30, 2019
Merged

Fixed #5793: fixed the alignment in search-in-workspace result node #5802

merged 1 commit into from
Jul 30, 2019

Conversation

fangnx
Copy link

@fangnx fangnx commented Jul 25, 2019

  • Fixed the alignment in the search-in-workspace result node. The close icon now is properly aligned with the notification count number icon.

theia-result-node-align

vince-fugnitto
vince-fugnitto approved these changes Jul 26, 2019
View reviewed changes
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works well for me, the alignment looks better :)
It's also similar to vscode where the X is place at the end of the line if the search
result contains multiple digits.

Screen Shot 2019-07-26 at 9 04 48 AM

Fixed eclipse-theia#5793: fixed the alignment in search-in-workspace …
809d381 
…result node

- Fixed the alignment in the search-in-workspace result node. The `close` icon now is properly aligned with the notification count number icon.

Signed-off-by: fangnx <naxin.fang@ericsson.com>
@fangnx fangnx changed the title Fixed 5793: fixed the alignment in search-in-workspace result node Fixed #5793: fixed the alignment in search-in-workspace result node Jul 29, 2019
@vince-fugnitto vince-fugnitto merged commit a54dd74 into eclipse-theia:master Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vince-fugnitto vince-fugnitto vince-fugnitto approved these changes

@jbicker jbicker Awaiting requested review from jbicker

@paul-marechal paul-marechal Awaiting requested review from paul-marechal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fangnx @vince-fugnitto