Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Developing an application against a fork of Theia #2192

Closed
thegecko opened this issue Jun 26, 2018 · 3 comments
Closed

Developing an application against a fork of Theia #2192

thegecko opened this issue Jun 26, 2018 · 3 comments
Labels
question user / developer questions

Comments

@thegecko
Copy link
Member

During last week's dev meeting there was a discussion around ways to develop against Theia, specifically when a developer needs to take advantage of features which aren't yet published or still under proposal.

This is primarily difficult due to Theia being a monorepo and npm/yarn not being able to install packages from within a repo. Short of publishing newer/modified packages to a different registry, setting up this environment has been a little tricky, so I thought I'd share a pattern for using git submodules to bring in Theia packages as a separate workspace. The project can be seen here:

https://github.com/thegecko/theia-dev

I've had to copy a lot of the package dependencies into the root package.json as AFAICT each package doesn't contain all of it's required dependencies.

Are there any thoughts around this approach? Can we make it simpler (perhaps by bringing all dependencies into each package)? Has anyone refined a better setup? Could something like this be turned into a starter project?

@akosyakov
Copy link
Member

akosyakov commented Jul 4, 2018

My concern is that it does not respect yarn.lock files in theia and extension repos, but creates a new one with different node_modules structure and packages' versions. So If it compiles and runs within such repo, it does not mean that it will within theia or extension repos. If it would not be an issue, it can be simplified by moving dev dependencies from the root to a single dev package and listing it as a workspace.

I wonder whether an approach with a local npm repo can work, e.g. with https://github.com/verdaccio/verdaccio.

@vince-fugnitto vince-fugnitto added the question user / developer questions label Mar 8, 2021
@JonasHelming
Copy link
Contributor

@thegecko : This has been inactive for quite a while. Can we close this or convert to a dicussion?

@thegecko
Copy link
Member Author

thegecko commented Aug 9, 2021

Perhaps convert?

@eclipse-theia eclipse-theia locked and limited conversation to collaborators Aug 9, 2021

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
question user / developer questions
Projects
None yet
Development

No branches or pull requests

4 participants