Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with unregisterOption (with Test) #80

Merged

Conversation

JackCA
Copy link

@JackCA JackCA commented Nov 3, 2015

This is a dupe of #75 but with a test (and minor change in syntax).

@JackCA JackCA force-pushed the fix-option-destroy-without-select branch from aeffb18 to b43731d Compare November 3, 2015 23:43
@Robdel12
Copy link
Collaborator

Robdel12 commented Nov 4, 2015

This looks really good to me. 👍 Thanks for all of the work!

Robdel12 added a commit that referenced this pull request Nov 4, 2015
Fix issue with unregisterOption (with Test)
@Robdel12 Robdel12 merged commit 195841a into adopted-ember-addons:master Nov 4, 2015
@JackCA
Copy link
Author

JackCA commented Nov 4, 2015

@Robdel12 no problem! Thanks for all of your team's help and for the library 😎

@JackCA JackCA deleted the fix-option-destroy-without-select branch November 4, 2015 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants