Use didRender in x-option
#53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the [ember 1.13.0][ember] release notes, `didRender` will be called after the element is inserted. This makes manually scheduling code to the `afterRender` queue obsolete. ``` DEPRECATION: A property of <my-app@view:-outlet::ember547> was modified inside the `didInsertElement` hook. You should never change properties on components, services or models during `didInsertElement` because it causes significant performance degradation. ``` [ember]: http://emberjs.com/blog/2015/06/12/ember-1-13-0-released.html
seanpdoyle
force-pushed
the
sd-deprecations
branch
from
04d5702 to
92579e7
Compare
|
+1 to merge this, this should resolve the deprecation messages Ember 1.13+ users have been experiencing. |
|
@Robdel12 has this been fixed already in the 2.0 target branch? |
|
Err, I think this is good. We just have to make sure once this is merged we're done with anything that isn't glimmer. |
Robdel12
added a commit
that referenced
this pull request
Aug 11, 2015
Use `didRender` in `x-option`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the ember 1.13.0 release notes,
didRenderwillbe called after the element is inserted.
This makes manually scheduling code to the
afterRenderqueue obsolete.