ember-cli-update to 2.16 #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dhaulagiri
commented
Nov 22, 2017
| @@ -75,13 +75,13 @@ describe('Integration: XSelectActionsComponent', function() { | |||
| {{#xs.option value="Hello"}}Hello{{/xs.option}} | |||
| {{/x-select}} | |||
| `); | |||
| Ember.warn = sinon.spy(); | |||
| warn = sinon.spy(); | |||
There was a problem hiding this comment.
@rwjblue I had pinged you about this a couple months ago in the ember-cli-babel repo but lost track of it while on leave. With this change here things blow up because warn is undefined. Is there a better way to do this with the new modules api?
There was a problem hiding this comment.
correction, the error is:
"warn" is read-only
Dhaulagiri
force-pushed
the
br-2.16
branch
2 times, most recently
from
564736e to
a7c97f1
Compare
|
@Dhaulagiri In order to spy on |
|
@cowboyd in the interest of unblocking this I undid the modules change to that test file since it is not really critical at this point. I still think there is something wrong with how |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Putting this out here in hopes that someone can help me push this across the finish line. I'll leave a comment on the problem areas.