reduce number of components searched #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit has 2 goals: 1) A small refactoring of the getValue method to split out the multiple/single value cases. 2) Decrease the number of elements `_getValue` searches through if possible. `Array.prototype.find` stops iterating on the array when the callback returns truthy. `options` is an `Ember.A` which means it should polyfill the `Array.prototype.find` method. Say you have an array like: ```javascript const values = [1, 2, 3]; ``` If we're looking for the value `2`, we only want to search the array two times, because the number 2 is found on the second iteration. This reduces the amount of work we have to do on larger arrays because we can bail if the element is found early. While this doesn't matter much on an array of 5, it can matter more with bigger arrays especially since we're querying the DOM.
|
You da best @fivetanley. Thanks for fixing x-select up :p |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit has 2 goals:
multiple/single value cases.
_getValuesearches through ifpossible.
Array.prototype.findstops iterating on the array when thecallback returns truthy.
optionsis anEmber.Awhich means it shouldpolyfill the
Array.prototype.findmethod.Say you have an array like:
If we're looking for the value
2, we only want to search the array twotimes, because the number 2 is found on the second iteration.
This reduces the amount of work we have to do on larger arrays because
we can bail if the element is found early. While this doesn't matter
much on an array of 5, it can matter more with bigger arrays especially
since we're querying the DOM.