coalesce registering and unregistering options #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tl;dr we can call the `_setDefaultValues()` function only once when rendering a bunch of components or destroying a bunch of components. If you have a list with a large amount of selects (~ >40 in our app), the `_setDefaultValues` function can get pretty expensive as it has to query the DOM every time. This gets slowly more costly to query as registering 40 `<option>` elements calls the `_setDefaultValues` function 40 times. In addition to the 40 times the function is called, the number of elements slowly grows as well. This ends up being O(n^2\2).
|
Love it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tl;dr we can call the
_setDefaultValues()function only once when renderinga bunch of components or destroying a bunch of components.
If you have a list with a large amount of selects (~ 40 in our app),
the
_setDefaultValuesfunction can get pretty expensive as it has to querythe DOM every time. This gets slowly more costly to query as registering
40
<option>elements calls the_setDefaultValuesfunction 40 times.In addition to the 40 times the function is called, the number of
elements slowly grows as well. This ends up being n^2\2. After this PR, it's just 1 time.