x-select contextual components only #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -111,7 +98,8 @@ export default Ember.Component.extend({ | |||
| * @return {Array|Object} the current selection | |||
| */ | |||
| _getValue() { | |||
| let options = this.get('options').filter(function(option) { | |||
| // TODO: childViews is a private property. Find something else. | |||
There was a problem hiding this comment.
@rwjblue just curious, why is childViews private?
And go back to a registration approach.
Robdel12
force-pushed
the
contextual-components-only
branch
from
b3cd3e7 to
889f76c
Compare
Robdel12
force-pushed
the
contextual-components-only
branch
from
12a10bf to
e7ca1ea
Compare
Robdel12
changed the title
Robdel12
added a commit
that referenced
this pull request
Sep 4, 2016
* Make x-option contextual * Stop using private property `childViews` And go back to a registration approach. * Add documentation for the actions. * Update readme examples for contextual components.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still need to do a little bit more cleanup work.