Support RSS feeds for specific topics (essentially combining current /feed and /topic functionality)
#430
+193
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nezteb
commented
Oct 3, 2022
Comment on lines
+204
to
+231
| defp setup_topic_feed_tests(context) do | ||
| # Add some topics | ||
| t1 = insert(:topic, slug: "rust", name: "Rust", description: "Rust is a systems programming language created by Mozilla.") | ||
| # Create some news items | ||
| ni1 = insert(:published_news_item, headline: "Rust is pretty cool", story: "Use it or lose it") | ||
| # Associate those news items with topics | ||
| nit1 = insert(:news_item_topic, topic: t1, news_item: ni1) | ||
|
|
||
| # Add a post | ||
| post1 = insert(:published_post, body: "Can you believe this Rust thing?!") | ||
| pt1 = insert(:post_topic, post: post1, topic: t1) | ||
|
|
||
| # Add a podcast | ||
| pod1 = insert(:podcast, name: "Rust Crust", slug: "rustcrust", description: "Rust is neat") | ||
| # Add a podcast episode | ||
| e1 = insert(:published_episode, podcast: pod1) | ||
| # Associate that episode with a topic | ||
| et1 = insert(:episode_topic, episode: e1, topic: t1) | ||
|
|
||
| %{ | ||
| topics: %{ | ||
| "rust" => t1 | ||
| }, | ||
| news_items_with_topics: [nit1], | ||
| posts_with_topics: [pt1], | ||
| podcast_episodes_with_topics: [et1] | ||
| } | ||
| end |
There was a problem hiding this comment.
1) test Topic feed the topic's podcasts feed (ChangelogWeb.FeedControllerTest)
test/changelog_web/controllers/feed_controller_test.exs:175
Assertion with =~ failed
code: assert conn.resp_body =~ post_with_topic.post.title
left: "<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n<rss version=\"2.0\" xmlns:dc=\"http://purl.org/dc/elements/1.1/\" xmlns:atom=\"http://www.w3.org/2005/Atom\" xmlns:itunes=\"http://www.itunes.com/dtds/podcast-1.0.dtd\">\n <channel>\n <title>Changelog: Rust</title>\n <copyright>All rights reserved</copyright>\n <link>http://localhost:4001/</link>\n <atom:link href=\"http://localhost:4001/feed\" rel=\"self\" type=\"application/rss+xml\" />\n <atom:link href=\"http://localhost:4001/\" rel=\"alternate\" type=\"text/html\" />\n <language>en-us</language>\n <description>Rust is a systems programming language created by Mozilla.</description>\n \n </channel>\n</rss>\n"
right: "Post 4"
stacktrace:
test/changelog_web/controllers/feed_controller_test.exs:193: anonymous fn/2 in ChangelogWeb.FeedControllerTest."test Topic feed the topic's podcasts feed"/1
(elixir 1.13.4) lib/enum.ex:937: Enum."-each/2-lists^foreach/1-0-"/2
test/changelog_web/controllers/feed_controller_test.exs:192: (test)
Currently trying to figure out why this test is failing. I think my test setup with the various ExMachina insert statements isn't set up correctly. 🤔 I'll hack at it some more soon!
ken-kost
reviewed
May 13, 2023
| |> filter_items_by_topic(:all) | ||
| |> fetch_items_by_topic() | ||
|
|
||
| render_topic(conn, slug, items) |
There was a problem hiding this comment.
render_topic(conn, topic, items) 🐛
|
In router First one should be |
ken-kost
suggested changes
May 13, 2023
| <description><%= @topic_description %></description> | ||
| <%= for item <- @items do %> | ||
| <item> | ||
| <%= render_item(item, assigns) %> |
There was a problem hiding this comment.
This pattern matches to def render_item(item = %{object: nil}, assigns) do ... because a NewsItem struct is returned. Maybe the query should be changed so that it returns only the preloaded posts of the specific topic. wdyt? 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #384
Original PR I branched off of: #390