Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abbreviated site symmetry groups in bandreps #38

Open
thchr opened this issue Mar 15, 2022 · 1 comment
Open

Abbreviated site symmetry groups in bandreps #38

thchr opened this issue Mar 15, 2022 · 1 comment

Comments

@thchr
Copy link
Owner

thchr commented Mar 15, 2022

The site symmetry group labels are abbreviated in the 3D listings returned by bandreps (because they are abbreviated in Bilbao's BANDREP program). As an example, in e.g. space group 163, we have site symmetry groups "32" - but what we'd like to have are the labels of site symmetry groups we use elsewhere (e.g., "321" or "312").

The issue with not having having this abbreviated is that we cannot e.g. pass the site symmetry group label to the IUC2SCHOENFLIES dictionary which expects the full IUC labels and not abbreviated ones.

We can't just fix these by just replacing "32" by "321" because it could just as well be "312". Instead, we should just search for what the actual Wyckoff positions site symmetry group is and then replace it accordingly.

Longer term, the BandRep struct should probably just embed a SiteGroup instead of having the wyck and sitesym fields...

@thchr
Copy link
Owner Author

thchr commented Sep 17, 2024

Steps have been taken towards improving this with calc_bandreps now returning a NewBandRep that contains all the above info and is better structured than BandRep. Still need to transition to this fully, longer term.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant