diff --git a/.circleci/config.yml b/.circleci/config.yml index 5ae0ddc91e..5676f44d66 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -19,7 +19,7 @@ jobs: # require credentials. Env variables that sets up these tests will work only for these kind of PRs. command: | if ! [ -z ${GCP_PROJECT} ]; then - echo $GOOGLE_APPLICATION_CREDENTIALS_CONTENT > /go/src/github.com/thanos-io/thanos/circleci-gcs-creds.json + echo $GOOGLE_APPLICATION_CREDENTIALS_CONTENT > $GOOGLE_APPLICATION_CREDENTIALS echo "Awesome! GCS integration tests are enabled." fi - run: make check-go-mod @@ -75,7 +75,7 @@ jobs: - run: ln -s .build/linux-amd64/thanos thanos - run: make docker - run: docker run thanos --help - - run: docker login -u="${QUAY_USERNAME}" -p="${QUAY_PASSWORD}" quay.io + - run: echo "${QUAY_PASSWORD}" | docker login -u="${QUAY_USERNAME}" quay.io --password-stdin - run: make docker-push publish_release: @@ -98,7 +98,7 @@ jobs: - run: ln -s .build/linux-amd64/thanos thanos - run: make docker - run: docker run thanos --help - - run: docker login -u="${QUAY_USERNAME}" -p="${QUAY_PASSWORD}" quay.io + - run: echo "${QUAY_PASSWORD}" | docker login -u="${QUAY_USERNAME}" quay.io --password-stdin - run: make docker-push DOCKER_IMAGE_TAG=$CIRCLE_TAG workflows: diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md index 65b604ef41..3c0d9902c6 100644 --- a/.github/ISSUE_TEMPLATE.md +++ b/.github/ISSUE_TEMPLATE.md @@ -6,7 +6,7 @@ about what components it touches e.g "query:" or ".*:" --> **Thanos, Prometheus and Golang version used** diff --git a/CHANGELOG.md b/CHANGELOG.md index 0e15c2bdf4..62b2e874a8 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -11,33 +11,33 @@ We use *breaking* word for marking changes that are not backward compatible (rel ## Unreleased. -- [#1338](https://github.com/improbable-eng/thanos/pull/1338) Querier still warns on store API duplicate, but allows a single one from duplicated set. This is gracefully warn about the problematic logic and not disrupt immediately. +- [#1338](https://github.com/thanos-io/thanos/pull/1338) Querier still warns on store API duplicate, but allows a single one from duplicated set. This is gracefully warn about the problematic logic and not disrupt immediately. ### Fixed -- [#1327](https://github.com/improbable-eng/thanos/pull/1327) `/series` API end-point now properly returns an empty array just like Prometheus if there are no results +- [#1327](https://github.com/thanos-io/thanos/pull/1327) `/series` API end-point now properly returns an empty array just like Prometheus if there are no results -## [v0.6.0](https://github.com/improbable-eng/thanos/releases/tag/v0.6.0) - 2019.07.18 +## [v0.6.0](https://github.com/thanos-io/thanos/releases/tag/v0.6.0) - 2019.07.18 ### Added -- [#1097](https://github.com/improbable-eng/thanos/pull/1097) Added `thanos check rules` linter for Thanos rule rules files. +- [#1097](https://github.com/thanos-io/thanos/pull/1097) Added `thanos check rules` linter for Thanos rule rules files. -- [#1253](https://github.com/improbable-eng/thanos/pull/1253) Add support for specifying a maximum amount of retries when using Azure Blob storage (default: no retries). +- [#1253](https://github.com/thanos-io/thanos/pull/1253) Add support for specifying a maximum amount of retries when using Azure Blob storage (default: no retries). -- [#1244](https://github.com/improbable-eng/thanos/pull/1244) Thanos Compact now exposes new metrics `thanos_compact_downsample_total` and `thanos_compact_downsample_failures_total` which are useful to catch when errors happen +- [#1244](https://github.com/thanos-io/thanos/pull/1244) Thanos Compact now exposes new metrics `thanos_compact_downsample_total` and `thanos_compact_downsample_failures_total` which are useful to catch when errors happen -- [#1260](https://github.com/improbable-eng/thanos/pull/1260) Thanos Query/Rule now exposes metrics `thanos_querier_store_apis_dns_provider_results` and `thanos_ruler_query_apis_dns_provider_results` which tell how many addresses were configured and how many were actually discovered respectively +- [#1260](https://github.com/thanos-io/thanos/pull/1260) Thanos Query/Rule now exposes metrics `thanos_querier_store_apis_dns_provider_results` and `thanos_ruler_query_apis_dns_provider_results` which tell how many addresses were configured and how many were actually discovered respectively -- [#1248](https://github.com/improbable-eng/thanos/pull/1248) Add a web UI to show the state of remote storage. +- [#1248](https://github.com/thanos-io/thanos/pull/1248) Add a web UI to show the state of remote storage. -- [#1217](https://github.com/improbable-eng/thanos/pull/1217) Thanos Receive gained basic hashring support +- [#1217](https://github.com/thanos-io/thanos/pull/1217) Thanos Receive gained basic hashring support -- [#1262](https://github.com/improbable-eng/thanos/pull/1262) Thanos Receive got a new metric `thanos_http_requests_total` which shows how many requests were handled by it +- [#1262](https://github.com/thanos-io/thanos/pull/1262) Thanos Receive got a new metric `thanos_http_requests_total` which shows how many requests were handled by it -- [#1243](https://github.com/improbable-eng/thanos/pull/1243) Thanos Receive got an ability to forward time series data between nodes. Now you can pass the hashring configuration via `--receive.hashrings-file`; the refresh interval `--receive.hashrings-file-refresh-interval`; the name of the local node's name `--receive.local-endpoint`; and finally the header's name which is used to determine the tenant `--receive.tenant-header`. +- [#1243](https://github.com/thanos-io/thanos/pull/1243) Thanos Receive got an ability to forward time series data between nodes. Now you can pass the hashring configuration via `--receive.hashrings-file`; the refresh interval `--receive.hashrings-file-refresh-interval`; the name of the local node's name `--receive.local-endpoint`; and finally the header's name which is used to determine the tenant `--receive.tenant-header`. -- [#1147](https://github.com/improbable-eng/thanos/pull/1147) Support for the Jaeger tracer has been added! +- [#1147](https://github.com/thanos-io/thanos/pull/1147) Support for the Jaeger tracer has been added! *breaking* New common flags were added for configuring tracing: `--tracing.config-file` and `--tracing.config`. You can either pass a file to Thanos with the tracing configuration or pass it in the command line itself. Old `--gcloudtrace.*` flags were removed :warning: @@ -57,41 +57,41 @@ The other `type` you can use is `JAEGER` now. The `config` keys and values are J ### Changed -- [#1284](https://github.com/improbable-eng/thanos/pull/1284) Add support for multiple label-sets in Info gRPC service. +- [#1284](https://github.com/thanos-io/thanos/pull/1284) Add support for multiple label-sets in Info gRPC service. This deprecates the single `Labels` slice of the `InfoResponse`, in a future release backward compatible handling for the single set of Labels will be removed. Upgrading to v0.6.0 or higher is advised. *breaking* If you run have duplicate queries in your Querier configuration with hierarchical federation of multiple Queries this PR makes Thanos Querier to detect this case and block all duplicates. Refer to 0.6.1 which at least allows for single replica to work. -- [#1314](https://github.com/improbable-eng/thanos/pull/1314) Removes `http_request_duration_microseconds` (Summary) and adds `http_request_duration_seconds` (Histogram) from http server instrumentation used in Thanos APIs and UIs. +- [#1314](https://github.com/thanos-io/thanos/pull/1314) Removes `http_request_duration_microseconds` (Summary) and adds `http_request_duration_seconds` (Histogram) from http server instrumentation used in Thanos APIs and UIs. -- [#1287](https://github.com/improbable-eng/thanos/pull/1287) Sidecar now waits on Prometheus' external labels before starting the uploading process +- [#1287](https://github.com/thanos-io/thanos/pull/1287) Sidecar now waits on Prometheus' external labels before starting the uploading process -- [#1261](https://github.com/improbable-eng/thanos/pull/1261) Thanos Receive now exposes metrics `thanos_http_request_duration_seconds` and `thanos_http_response_size_bytes` properly of each handler +- [#1261](https://github.com/thanos-io/thanos/pull/1261) Thanos Receive now exposes metrics `thanos_http_request_duration_seconds` and `thanos_http_response_size_bytes` properly of each handler -- [#1274](https://github.com/improbable-eng/thanos/pull/1274) Iteration limit has been lifted from the LRU cache so there should be no more spam of error messages as they were harmless +- [#1274](https://github.com/thanos-io/thanos/pull/1274) Iteration limit has been lifted from the LRU cache so there should be no more spam of error messages as they were harmless -- [#1321](https://github.com/improbable-eng/thanos/pull/1321) Thanos Query now fails early on a query which only uses external labels - this improves clarity in certain situations +- [#1321](https://github.com/thanos-io/thanos/pull/1321) Thanos Query now fails early on a query which only uses external labels - this improves clarity in certain situations ### Fixed -- [#1227](https://github.com/improbable-eng/thanos/pull/1227) Some context handling issues were fixed in Thanos Compact; some unnecessary memory allocations were removed in the hot path of Thanos Store. +- [#1227](https://github.com/thanos-io/thanos/pull/1227) Some context handling issues were fixed in Thanos Compact; some unnecessary memory allocations were removed in the hot path of Thanos Store. -- [#1183](https://github.com/improbable-eng/thanos/pull/1183) Compactor now correctly propagates retriable/haltable errors which means that it will not unnecessarily restart if such an error occurs +- [#1183](https://github.com/thanos-io/thanos/pull/1183) Compactor now correctly propagates retriable/haltable errors which means that it will not unnecessarily restart if such an error occurs -- [#1231](https://github.com/improbable-eng/thanos/pull/1231) Receive now correctly handles SIGINT and closes without deadlocking +- [#1231](https://github.com/thanos-io/thanos/pull/1231) Receive now correctly handles SIGINT and closes without deadlocking -- [#1278](https://github.com/improbable-eng/thanos/pull/1278) Fixed inflated values problem with `sum()` on Thanos Query +- [#1278](https://github.com/thanos-io/thanos/pull/1278) Fixed inflated values problem with `sum()` on Thanos Query -- [#1280](https://github.com/improbable-eng/thanos/pull/1280) Fixed a problem with concurrent writes to a `map` in Thanos Query while rendering the UI +- [#1280](https://github.com/thanos-io/thanos/pull/1280) Fixed a problem with concurrent writes to a `map` in Thanos Query while rendering the UI -- [#1311](https://github.com/improbable-eng/thanos/pull/1311) Fixed occasional panics in Compact and Store when using Azure Blob cloud storage caused by lack of error checking in client library. +- [#1311](https://github.com/thanos-io/thanos/pull/1311) Fixed occasional panics in Compact and Store when using Azure Blob cloud storage caused by lack of error checking in client library. -- [#1322](https://github.com/improbable-eng/thanos/pull/1322) Removed duplicated closing of the gRPC listener - this gets rid of harmless messages like `store gRPC listener: close tcp 0.0.0.0:10901: use of closed network connection` when those programs are being closed +- [#1322](https://github.com/thanos-io/thanos/pull/1322) Removed duplicated closing of the gRPC listener - this gets rid of harmless messages like `store gRPC listener: close tcp 0.0.0.0:10901: use of closed network connection` when those programs are being closed ### Deprecated -- [#1216](https://github.com/improbable-eng/thanos/pull/1216) the old "Command-line flags" has been removed from Thanos Query UI since it was not populated and because we are striving for consistency +- [#1216](https://github.com/thanos-io/thanos/pull/1216) the old "Command-line flags" has been removed from Thanos Query UI since it was not populated and because we are striving for consistency -## [v0.5.0](https://github.com/improbable-eng/thanos/releases/tag/v0.5.0) - 2019.06.05 +## [v0.5.0](https://github.com/thanos-io/thanos/releases/tag/v0.5.0) - 2019.06.05 TL;DR: Store LRU cache is no longer leaking, Upgraded Thanos UI to Prometheus 2.9, Fixed auto-downsampling, Moved to Go 1.12.5 and more. @@ -101,21 +101,21 @@ This version moved tarballs to Golang 1.12.5 from 1.11 as well, so same warning ### Fixed -- [#1142](https://github.com/improbable-eng/thanos/pull/1142) fixed major leak on store LRU cache for index items (postings and series). -- [#1163](https://github.com/improbable-eng/thanos/pull/1163) sidecar is no longer blocking for custom Prometheus versions/builds. It only checks if flags return non 404, then it performs optional checks. -- [#1146](https://github.com/improbable-eng/thanos/pull/1146) store/bucket: make getFor() work with interleaved resolutions. -- [#1157](https://github.com/improbable-eng/thanos/pull/1157) querier correctly handles duplicated stores when some store changes external labels in place. +- [#1142](https://github.com/thanos-io/thanos/pull/1142) fixed major leak on store LRU cache for index items (postings and series). +- [#1163](https://github.com/thanos-io/thanos/pull/1163) sidecar is no longer blocking for custom Prometheus versions/builds. It only checks if flags return non 404, then it performs optional checks. +- [#1146](https://github.com/thanos-io/thanos/pull/1146) store/bucket: make getFor() work with interleaved resolutions. +- [#1157](https://github.com/thanos-io/thanos/pull/1157) querier correctly handles duplicated stores when some store changes external labels in place. ### Added -- [#1094](https://github.com/improbable-eng/thanos/pull/1094) Allow configuring the response header timeout for the S3 client. +- [#1094](https://github.com/thanos-io/thanos/pull/1094) Allow configuring the response header timeout for the S3 client. ### Changed -- [#1118](https://github.com/improbable-eng/thanos/pull/1118) *breaking* swift: Added support for cross-domain authentication by introducing `userDomainID`, `userDomainName`, `projectDomainID`, `projectDomainName`. +- [#1118](https://github.com/thanos-io/thanos/pull/1118) *breaking* swift: Added support for cross-domain authentication by introducing `userDomainID`, `userDomainName`, `projectDomainID`, `projectDomainName`. The outdated terms `tenantID`, `tenantName` are deprecated and have been replaced by `projectID`, `projectName`. -- [#1066](https://github.com/improbable-eng/thanos/pull/1066) Upgrade Thanos ui to Prometheus v2.9.1. +- [#1066](https://github.com/thanos-io/thanos/pull/1066) Upgrade Thanos ui to Prometheus v2.9.1. Changes from the upstream: * query: @@ -128,12 +128,12 @@ This version moved tarballs to Golang 1.12.5 from 1.11 as well, so same warning - [ENHANCEMENT] Improve rule views by wrapping lines [PR #4702](https://github.com/prometheus/prometheus/pull/4702) - [ENHANCEMENT] Show rule evaluation errors on rules page [PR #4457](https://github.com/prometheus/prometheus/pull/4457) -- [#1156](https://github.com/improbable-eng/thanos/pull/1156) Moved CI and docker multistage to Golang 1.12.5 for latest mem alloc improvements. -- [#1103](https://github.com/improbable-eng/thanos/pull/1103) Updated go-cos deps. (COS bucket client). -- [#1149](https://github.com/improbable-eng/thanos/pull/1149) Updated google Golang API deps (GCS bucket client). -- [#1190](https://github.com/improbable-eng/thanos/pull/1190) Updated minio deps (S3 bucket client). This fixes minio retries. +- [#1156](https://github.com/thanos-io/thanos/pull/1156) Moved CI and docker multistage to Golang 1.12.5 for latest mem alloc improvements. +- [#1103](https://github.com/thanos-io/thanos/pull/1103) Updated go-cos deps. (COS bucket client). +- [#1149](https://github.com/thanos-io/thanos/pull/1149) Updated google Golang API deps (GCS bucket client). +- [#1190](https://github.com/thanos-io/thanos/pull/1190) Updated minio deps (S3 bucket client). This fixes minio retries. -- [#1133](https://github.com/improbable-eng/thanos/pull/1133) Use prometheus v2.9.2, common v0.4.0 & tsdb v0.8.0. +- [#1133](https://github.com/thanos-io/thanos/pull/1133) Use prometheus v2.9.2, common v0.4.0 & tsdb v0.8.0. Changes from the upstreams: * store gateway: @@ -151,9 +151,9 @@ This version moved tarballs to Golang 1.12.5 from 1.11 as well, so same warning ## Deprecated -- [#1008](https://github.com/improbable-eng/thanos/pull/1008) *breaking* Removed Gossip implementation. All `--cluster.*` flags removed and Thanos will error out if any is provided. +- [#1008](https://github.com/thanos-io/thanos/pull/1008) *breaking* Removed Gossip implementation. All `--cluster.*` flags removed and Thanos will error out if any is provided. -## [v0.4.0](https://github.com/improbable-eng/thanos/releases/tag/v0.4.0) - 2019.05.3 +## [v0.4.0](https://github.com/thanos-io/thanos/releases/tag/v0.4.0) - 2019.05.3 :warning: **IMPORTANT** :warning: This is the last release that supports gossip. From Thanos v0.5.0, gossip will be completely removed. @@ -173,12 +173,12 @@ Using cadvisor `container_memory_usage_bytes` metric could be misleading e.g: ht ### Added - [thanos.io](https://thanos.io) website & automation :tada: -- [#1053](https://github.com/improbable-eng/thanos/pull/1053) compactor: Compactor & store gateway now handles incomplete uploads gracefully. Added hard limit on how long block upload can take (30m). -- [#811](https://github.com/improbable-eng/thanos/pull/811) Remote write receiver component :heart: :heart: thanks to RedHat (@brancz) contribution. -- [#910](https://github.com/improbable-eng/thanos/pull/910) Query's stores UI page is now sorted by type and old DNS or File SD stores are removed after 5 minutes (configurable via the new `--store.unhealthy-timeout=5m` flag). -- [#905](https://github.com/improbable-eng/thanos/pull/905) Thanos support for Query API: /api/v1/labels. Notice that the API was added in Prometheus v2.6. -- [#798](https://github.com/improbable-eng/thanos/pull/798) Ability to limit the maximum number of concurrent request to Series() calls in Thanos Store and the maximum amount of samples we handle. -- [#1060](https://github.com/improbable-eng/thanos/pull/1060) Allow specifying region attribute in S3 storage configuration +- [#1053](https://github.com/thanos-io/thanos/pull/1053) compactor: Compactor & store gateway now handles incomplete uploads gracefully. Added hard limit on how long block upload can take (30m). +- [#811](https://github.com/thanos-io/thanos/pull/811) Remote write receiver component :heart: :heart: thanks to RedHat (@brancz) contribution. +- [#910](https://github.com/thanos-io/thanos/pull/910) Query's stores UI page is now sorted by type and old DNS or File SD stores are removed after 5 minutes (configurable via the new `--store.unhealthy-timeout=5m` flag). +- [#905](https://github.com/thanos-io/thanos/pull/905) Thanos support for Query API: /api/v1/labels. Notice that the API was added in Prometheus v2.6. +- [#798](https://github.com/thanos-io/thanos/pull/798) Ability to limit the maximum number of concurrent request to Series() calls in Thanos Store and the maximum amount of samples we handle. +- [#1060](https://github.com/thanos-io/thanos/pull/1060) Allow specifying region attribute in S3 storage configuration :warning: **WARNING** :warning: #798 adds a new default limit to Thanos Store: `--store.grpc.series-max-concurrency`. Most likely you will want to make it the same as `--query.max-concurrent` on Thanos Query. @@ -199,33 +199,33 @@ New options: New Store tracing span: * `store_query_gate_ismyturn` shows how long it took for a query to pass (or not) through the gate. -- [#1016](https://github.com/improbable-eng/thanos/pull/1016) Added option for another DNS resolver (miekg/dns client). +- [#1016](https://github.com/thanos-io/thanos/pull/1016) Added option for another DNS resolver (miekg/dns client). Note that this is required to have SRV resolution working on [Golang 1.11+ with KubeDNS below v1.14](https://github.com/golang/go/issues/27546) New Querier and Ruler flag: `-- store.sd-dns-resolver` which allows to specify resolver to use. Either `golang` or `miekgdns` -- [#986](https://github.com/improbable-eng/thanos/pull/986) Allow to save some startup & sync time in store gateway as it is no longer needed to compute index-cache from block index on its own for larger blocks. +- [#986](https://github.com/thanos-io/thanos/pull/986) Allow to save some startup & sync time in store gateway as it is no longer needed to compute index-cache from block index on its own for larger blocks. The store Gateway still can do it, but it first checks bucket if there is index-cached uploaded already. In the same time, compactor precomputes the index cache file on every compaction. New Compactor flag: `--index.generate-missing-cache-file` was added to allow quicker addition of index cache files. If enabled it precomputes missing files on compactor startup. Note that it will take time and it's only one-off step per bucket. -- [#887](https://github.com/improbable-eng/thanos/pull/887) Compact: Added new `--block-sync-concurrency` flag, which allows you to configure number of goroutines to use when syncing block metadata from object storage. -- [#928](https://github.com/improbable-eng/thanos/pull/928) Query: Added `--store.response-timeout` flag. If a Store doesn't send any data in this specified duration then a Store will be ignored and partial data will be returned if it's enabled. 0 disables timeout. -- [#893](https://github.com/improbable-eng/thanos/pull/893) S3 storage backend has graduated to `stable` maturity level. -- [#936](https://github.com/improbable-eng/thanos/pull/936) Azure storage backend has graduated to `stable` maturity level. -- [#937](https://github.com/improbable-eng/thanos/pull/937) S3: added trace functionality. You can add `trace.enable: true` to enable the minio client's verbose logging. -- [#953](https://github.com/improbable-eng/thanos/pull/953) Compact: now has a hidden flag `--debug.accept-malformed-index`. Compaction index verification will ignore out of order label names. -- [#963](https://github.com/improbable-eng/thanos/pull/963) GCS: added possibility to inline ServiceAccount into GCS config. -- [#1010](https://github.com/improbable-eng/thanos/pull/1010) Compact: added new flag `--compact.concurrency`. Number of goroutines to use when compacting groups. -- [#1028](https://github.com/improbable-eng/thanos/pull/1028) Query: added `--query.default-evaluation-interval`, which sets default evaluation interval for sub queries. -- [#980](https://github.com/improbable-eng/thanos/pull/980) Ability to override Azure storage endpoint for other regions (China) -- [#1021](https://github.com/improbable-eng/thanos/pull/1021) Query API `series` now supports POST method. -- [#939](https://github.com/improbable-eng/thanos/pull/939) Query API `query_range` now supports POST method. +- [#887](https://github.com/thanos-io/thanos/pull/887) Compact: Added new `--block-sync-concurrency` flag, which allows you to configure number of goroutines to use when syncing block metadata from object storage. +- [#928](https://github.com/thanos-io/thanos/pull/928) Query: Added `--store.response-timeout` flag. If a Store doesn't send any data in this specified duration then a Store will be ignored and partial data will be returned if it's enabled. 0 disables timeout. +- [#893](https://github.com/thanos-io/thanos/pull/893) S3 storage backend has graduated to `stable` maturity level. +- [#936](https://github.com/thanos-io/thanos/pull/936) Azure storage backend has graduated to `stable` maturity level. +- [#937](https://github.com/thanos-io/thanos/pull/937) S3: added trace functionality. You can add `trace.enable: true` to enable the minio client's verbose logging. +- [#953](https://github.com/thanos-io/thanos/pull/953) Compact: now has a hidden flag `--debug.accept-malformed-index`. Compaction index verification will ignore out of order label names. +- [#963](https://github.com/thanos-io/thanos/pull/963) GCS: added possibility to inline ServiceAccount into GCS config. +- [#1010](https://github.com/thanos-io/thanos/pull/1010) Compact: added new flag `--compact.concurrency`. Number of goroutines to use when compacting groups. +- [#1028](https://github.com/thanos-io/thanos/pull/1028) Query: added `--query.default-evaluation-interval`, which sets default evaluation interval for sub queries. +- [#980](https://github.com/thanos-io/thanos/pull/980) Ability to override Azure storage endpoint for other regions (China) +- [#1021](https://github.com/thanos-io/thanos/pull/1021) Query API `series` now supports POST method. +- [#939](https://github.com/thanos-io/thanos/pull/939) Query API `query_range` now supports POST method. ### Changed -- [#970](https://github.com/improbable-eng/thanos/pull/970) Deprecated `partial_response_disabled` proto field. Added `partial_response_strategy` instead. Both in gRPC and Query API. +- [#970](https://github.com/thanos-io/thanos/pull/970) Deprecated `partial_response_disabled` proto field. Added `partial_response_strategy` instead. Both in gRPC and Query API. No `PartialResponseStrategy` field for `RuleGroups` by default means `abort` strategy (old PartialResponse disabled) as this is recommended option for Rules and alerts. Metrics: @@ -240,7 +240,7 @@ Note that this is required to have SRV resolution working on [Golang 1.11+ with * `/rule_instant_query HTTP[client]` is now `/rule_instant_query_part_resp_abort HTTP[client]"` if request is for abort strategy. -- [#1009](https://github.com/improbable-eng/thanos/pull/1009): Upgraded Prometheus (~v2.7.0-rc.0 to v2.8.1) and TSDB (`v0.4.0` to `v0.6.1`) deps. +- [#1009](https://github.com/thanos-io/thanos/pull/1009): Upgraded Prometheus (~v2.7.0-rc.0 to v2.8.1) and TSDB (`v0.4.0` to `v0.6.1`) deps. Changes that affects Thanos: * query: @@ -250,46 +250,46 @@ Note that this is required to have SRV resolution working on [Golang 1.11+ with * ruler: * [ENHANCEMENT] Reduce time that Alertmanagers are in flux when reloaded. #5126 * [BUGFIX] prometheus_rule_group_last_evaluation_timestamp_seconds is now a unix timestamp. #5186 - * [BUGFIX] prometheus_rule_group_last_duration_seconds now reports seconds instead of nanoseconds. Fixes our [issue #1027](https://github.com/improbable-eng/thanos/issues/1027) + * [BUGFIX] prometheus_rule_group_last_duration_seconds now reports seconds instead of nanoseconds. Fixes our [issue #1027](https://github.com/thanos-io/thanos/issues/1027) * [BUGFIX] Fix sorting of rule groups. #5260 * store: [ENHANCEMENT] Fast path for EmptyPostings cases in Merge, Intersect and Without. * tooling: [FEATURE] New dump command to tsdb tool to dump all samples. * compactor: * [ENHANCEMENT] When closing the db any running compaction will be cancelled so it doesn't block. - * [CHANGE] *breaking* Renamed flag `--sync-delay` to `--consistency-delay` [#1053](https://github.com/improbable-eng/thanos/pull/1053) + * [CHANGE] *breaking* Renamed flag `--sync-delay` to `--consistency-delay` [#1053](https://github.com/thanos-io/thanos/pull/1053) For ruler essentially whole TSDB CHANGELOG applies beween v0.4.0-v0.6.1: https://github.com/prometheus/tsdb/blob/master/CHANGELOG.md Note that this was added on TSDB and Prometheus: [FEATURE] Time-ovelapping blocks are now allowed. #370 Whoever due to nature of Thanos compaction (distributed systems), for safety reason this is disabled for Thanos compactor for now. -- [#868](https://github.com/improbable-eng/thanos/pull/868) Go has been updated to 1.12. -- [#1055](https://github.com/improbable-eng/thanos/pull/1055) Gossip flags are now disabled by default and deprecated. -- [#964](https://github.com/improbable-eng/thanos/pull/964) repair: Repair process now sorts the series and labels within block. -- [#1073](https://github.com/improbable-eng/thanos/pull/1073) Store: index cache for requests. It now calculates the size properly (includes slice header), has anti-deadlock safeguard and reports more metrics. +- [#868](https://github.com/thanos-io/thanos/pull/868) Go has been updated to 1.12. +- [#1055](https://github.com/thanos-io/thanos/pull/1055) Gossip flags are now disabled by default and deprecated. +- [#964](https://github.com/thanos-io/thanos/pull/964) repair: Repair process now sorts the series and labels within block. +- [#1073](https://github.com/thanos-io/thanos/pull/1073) Store: index cache for requests. It now calculates the size properly (includes slice header), has anti-deadlock safeguard and reports more metrics. ### Fixed -- [#921](https://github.com/improbable-eng/thanos/pull/921) `thanos_objstore_bucket_last_successful_upload_time` now does not appear when no blocks have been uploaded so far. -- [#966](https://github.com/improbable-eng/thanos/pull/966) Bucket: verify no longer warns about overlapping blocks, that overlap `0s` -- [#848](https://github.com/improbable-eng/thanos/pull/848) Compact: now correctly works with time series with duplicate labels. -- [#894](https://github.com/improbable-eng/thanos/pull/894) Thanos Rule: UI now correctly shows evaluation time. -- [#865](https://github.com/improbable-eng/thanos/pull/865) Query: now properly parses DNS SRV Service Discovery. -- [#889](https://github.com/improbable-eng/thanos/pull/889) Store: added safeguard against merging posting groups segfault -- [#941](https://github.com/improbable-eng/thanos/pull/941) Sidecar: added better handling of intermediate restarts. -- [#933](https://github.com/improbable-eng/thanos/pull/933) Query: Fixed 30 seconds lag of adding new store to query. -- [#962](https://github.com/improbable-eng/thanos/pull/962) Sidecar: Make config reloader file writes atomic. -- [#982](https://github.com/improbable-eng/thanos/pull/982) Query: now advertises Min & Max Time accordingly to the nodes. -- [#1041](https://github.com/improbable-eng/thanos/issues/1038) Ruler is now able to return long time range queries. -- [#904](https://github.com/improbable-eng/thanos/pull/904) Compact: Skip compaction for blocks with no samples. -- [#1070](https://github.com/improbable-eng/thanos/pull/1070) Downsampling works back again. Deferred closer errors are now properly captured. - -## [v0.3.2](https://github.com/improbable-eng/thanos/releases/tag/v0.3.2) - 2019.03.04 +- [#921](https://github.com/thanos-io/thanos/pull/921) `thanos_objstore_bucket_last_successful_upload_time` now does not appear when no blocks have been uploaded so far. +- [#966](https://github.com/thanos-io/thanos/pull/966) Bucket: verify no longer warns about overlapping blocks, that overlap `0s` +- [#848](https://github.com/thanos-io/thanos/pull/848) Compact: now correctly works with time series with duplicate labels. +- [#894](https://github.com/thanos-io/thanos/pull/894) Thanos Rule: UI now correctly shows evaluation time. +- [#865](https://github.com/thanos-io/thanos/pull/865) Query: now properly parses DNS SRV Service Discovery. +- [#889](https://github.com/thanos-io/thanos/pull/889) Store: added safeguard against merging posting groups segfault +- [#941](https://github.com/thanos-io/thanos/pull/941) Sidecar: added better handling of intermediate restarts. +- [#933](https://github.com/thanos-io/thanos/pull/933) Query: Fixed 30 seconds lag of adding new store to query. +- [#962](https://github.com/thanos-io/thanos/pull/962) Sidecar: Make config reloader file writes atomic. +- [#982](https://github.com/thanos-io/thanos/pull/982) Query: now advertises Min & Max Time accordingly to the nodes. +- [#1041](https://github.com/thanos-io/thanos/issues/1038) Ruler is now able to return long time range queries. +- [#904](https://github.com/thanos-io/thanos/pull/904) Compact: Skip compaction for blocks with no samples. +- [#1070](https://github.com/thanos-io/thanos/pull/1070) Downsampling works back again. Deferred closer errors are now properly captured. + +## [v0.3.2](https://github.com/thanos-io/thanos/releases/tag/v0.3.2) - 2019.03.04 ### Added -- [#851](https://github.com/improbable-eng/thanos/pull/851) New read API endpoint for api/v1/rules and api/v1/alerts. -- [#873](https://github.com/improbable-eng/thanos/pull/873) Store: fix set index cache LRU +- [#851](https://github.com/thanos-io/thanos/pull/851) New read API endpoint for api/v1/rules and api/v1/alerts. +- [#873](https://github.com/thanos-io/thanos/pull/873) Store: fix set index cache LRU :warning: **WARNING** :warning: #873 fix fixes actual handling of `index-cache-size`. Handling of limit for this cache was broken so it was unbounded all the time. From this release actual value matters and is extremely low by default. To "revert" @@ -297,18 +297,18 @@ the old behaviour (no boundary), use a large enough value. ### Fixed -- [#833](https://github.com/improbable-eng/thanos/issues/833) Store Gateway matcher regression for intersecting with empty posting. -- [#867](https://github.com/improbable-eng/thanos/pull/867) Fixed race condition in sidecare between reloader and shipper. +- [#833](https://github.com/thanos-io/thanos/issues/833) Store Gateway matcher regression for intersecting with empty posting. +- [#867](https://github.com/thanos-io/thanos/pull/867) Fixed race condition in sidecare between reloader and shipper. -## [v0.3.1](https://github.com/improbable-eng/thanos/releases/tag/v0.3.1) - 2019.02.18 +## [v0.3.1](https://github.com/thanos-io/thanos/releases/tag/v0.3.1) - 2019.02.18 ### Fixed -- [#829](https://github.com/improbable-eng/thanos/issues/829) Store Gateway crashing due to `slice bounds out of range`. -- [#834](https://github.com/improbable-eng/thanos/issues/834) Store Gateway matcher regression for `<>` `!=`. +- [#829](https://github.com/thanos-io/thanos/issues/829) Store Gateway crashing due to `slice bounds out of range`. +- [#834](https://github.com/thanos-io/thanos/issues/834) Store Gateway matcher regression for `<>` `!=`. -## [v0.3.0](https://github.com/improbable-eng/thanos/releases/tag/v0.3.0) - 2019.02.08 +## [v0.3.0](https://github.com/thanos-io/thanos/releases/tag/v0.3.0) - 2019.02.08 ### Added @@ -322,17 +322,17 @@ the old behaviour (no boundary), use a large enough value. ### Fixed -- [#649](https://github.com/improbable-eng/thanos/issues/649) - Fixed store label values api to add also external label values. -- [#396](https://github.com/improbable-eng/thanos/issues/396) - Fixed sidecar logic for proxying series that has more than 2^16 samples from Prometheus. -- [#732](https://github.com/improbable-eng/thanos/pull/732) - Fixed S3 authentication sequence. You can see new sequence enumerated [here](https://github.com/improbable-eng/thanos/blob/master/docs/storage.md#aws-s3-configuration) -- [#745](https://github.com/improbable-eng/thanos/pull/745) - Fixed race conditions and edge cases for Thanos Querier fanout logic. -- [#651](https://github.com/improbable-eng/thanos/issues/651) - Fixed index cache when asked buffer size is bigger than cache max size. +- [#649](https://github.com/thanos-io/thanos/issues/649) - Fixed store label values api to add also external label values. +- [#396](https://github.com/thanos-io/thanos/issues/396) - Fixed sidecar logic for proxying series that has more than 2^16 samples from Prometheus. +- [#732](https://github.com/thanos-io/thanos/pull/732) - Fixed S3 authentication sequence. You can see new sequence enumerated [here](https://github.com/thanos-io/thanos/blob/master/docs/storage.md#aws-s3-configuration) +- [#745](https://github.com/thanos-io/thanos/pull/745) - Fixed race conditions and edge cases for Thanos Querier fanout logic. +- [#651](https://github.com/thanos-io/thanos/issues/651) - Fixed index cache when asked buffer size is bigger than cache max size. ### Changed -- [#529](https://github.com/improbable-eng/thanos/pull/529) Massive improvement for compactor. Downsampling memory consumption was reduce to only store labels and single chunks per each series. +- [#529](https://github.com/thanos-io/thanos/pull/529) Massive improvement for compactor. Downsampling memory consumption was reduce to only store labels and single chunks per each series. - Qurerier UI: Store page now shows the store APIs per component type. -- Prometheus and TSDB deps are now up to date with ~2.7.0 Prometheus version. Lot's of things has changed. See details [here #704](https://github.com/improbable-eng/thanos/pull/704) Known changes that affects us: +- Prometheus and TSDB deps are now up to date with ~2.7.0 Prometheus version. Lot's of things has changed. See details [here #704](https://github.com/thanos-io/thanos/pull/704) Known changes that affects us: - prometheus/prometheus/discovery/file - [ENHANCEMENT] Discovery: Improve performance of previously slow updates of changes of targets. #4526 - [BUGFIX] Wait for service discovery to stop before exiting #4508 ?? @@ -356,9 +356,9 @@ the old behaviour (no boundary), use a large enough value. ### Deprecated -- Tests against Prometheus below v2.2.1. This does not mean *lack* of support for those. Only that we don't tests the compatibility anymore. See [#758](https://github.com/improbable-eng/thanos/issues/758) for details. +- Tests against Prometheus below v2.2.1. This does not mean *lack* of support for those. Only that we don't tests the compatibility anymore. See [#758](https://github.com/thanos-io/thanos/issues/758) for details. -## [v0.2.1](https://github.com/improbable-eng/thanos/releases/tag/v0.2.1) - 2018.12.27 +## [v0.2.1](https://github.com/thanos-io/thanos/releases/tag/v0.2.1) - 2018.12.27 ### Added @@ -374,7 +374,7 @@ the old behaviour (no boundary), use a large enough value. - Move handling of HA alertmanagers to be the same as Prometheus. - Azure iteration implementation flaw. -## [v0.2.0](https://github.com/improbable-eng/thanos/releases/tag/v0.2.0) - 2018.12.10 +## [v0.2.0](https://github.com/thanos-io/thanos/releases/tag/v0.2.0) - 2018.12.10 Next Thanos release adding support to new discovery method, gRPC mTLS and two new object store providers (Swift and Azure). @@ -433,7 +433,7 @@ Note lots of necessary breaking changes in flags that relates to bucket configur - Sidecar too frequent Prometheus reload. - `thanos_compactor_retries_total` metric not being registered. -## [v0.1.0](https://github.com/improbable-eng/thanos/releases/tag/v0.1.0) - 2018.09.14 +## [v0.1.0](https://github.com/thanos-io/thanos/releases/tag/v0.1.0) - 2018.09.14 Initial version to have a stable reference before [gossip protocol removal](/docs/proposals/completed/201809_gossip-removal.md). diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 2f02178c76..7ba9d06691 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -29,10 +29,10 @@ Adding large new features and components to Thanos should be done by first creat 1. Read [getting started docs](docs/getting-started.md) and prepare Thanos. 2. Familiarize yourself with [Makefile](Makefile) commands like `format`, `build`, `proto` and `test`. -3. Fork improbable-eng/thanos.git and start development from your own fork. Here are sample steps to setup your development environment: +3. Fork thanos-io/thanos.git and start development from your own fork. Here are sample steps to setup your development environment: ```console -$ mkdir -p $GOPATH/src/github.com/improbable-eng -$ cd $GOPATH/src/github.com/improbable-eng +$ mkdir -p $GOPATH/src/github.com/thanos-io +$ cd $GOPATH/src/github.com/thanos-io $ git clone https://github.com//thanos.git $ cd thanos $ git remote add upstream https://github.com/thanos-io/thanos.git diff --git a/MAINTAINERS.md b/MAINTAINERS.md index ab045f2ea8..7cb90239f0 100644 --- a/MAINTAINERS.md +++ b/MAINTAINERS.md @@ -35,7 +35,7 @@ Please reach any of the maintainer on slack or email if you want to help as well ### Triage labels -To improve navigating through issues and PRs we introduce various [labels](https://github.com/improbable-eng/thanos/issues/labels). Part of triaging process for Triage and Maintainers +To improve navigating through issues and PRs we introduce various [labels](https://github.com/thanos-io/thanos/issues/labels). Part of triaging process for Triage and Maintainers is to adjust those labels if needed manual. The `Prow` system can automate a portion of this in future. The main labels are: diff --git a/README.md b/README.md index 9675e27473..5493dda4e1 100644 --- a/README.md +++ b/README.md @@ -1,6 +1,6 @@

Thanos Logo

-[![CircleCI](https://circleci.com/gh/improbable-eng/thanos.svg?style=svg)](https://circleci.com/gh/improbable-eng/thanos) +[![CircleCI](https://circleci.com/gh/thanos-io/thanos.svg?style=svg)](https://circleci.com/gh/thanos-io/thanos) [![Go Report Card](https://goreportcard.com/badge/github.com/thanos-io/thanos)](https://goreportcard.com/report/github.com/thanos-io/thanos) [![GoDoc](https://godoc.org/github.com/thanos-io/thanos?status.svg)](https://godoc.org/github.com/thanos-io/thanos) [![Slack](https://img.shields.io/badge/join%20slack-%23thanos-brightgreen.svg)](https://slack.cncf.io/) @@ -33,7 +33,7 @@ Concretely the aims of the project are: * [Design](https://thanos.io/design.md/) * [Prom Meetup Slides](https://www.slideshare.net/BartomiejPotka/thanos-global-durable-prometheus-monitoring) * [Introduction blog post](https://improbable.io/games/blog/thanos-prometheus-at-scale) -* [Benchmarks](https://github.com/improbable-eng/thanos/tree/master/benchmark) +* [Benchmarks](https://github.com/thanos-io/thanos/tree/master/benchmark) * [Proposals](docs/proposals) * [Integrations](docs/integrations.md) diff --git a/benchmark/README.md b/benchmark/README.md index 2a410d84eb..21c9389f82 100644 --- a/benchmark/README.md +++ b/benchmark/README.md @@ -1,8 +1,8 @@ # Thanosbench -A series of benchmarking/stress test tools for [thanos](https://github.com/improbable-eng/thanos). +A series of benchmarking/stress test tools for [thanos](https://github.com/thanos-io/thanos). ## Installation -1. Fetch thanosbench `go get github.com/improbable-eng/thanosbench` +1. Fetch thanosbench `go get github.com/thanos-io/thanosbench` 1. Install thanosbench with `make` 1. Create cloud resources for the load test k8s cluster. * `cd terraform` diff --git a/docs/components/rule.md b/docs/components/rule.md index 654d6a5299..81bda6c2ff 100644 --- a/docs/components/rule.md +++ b/docs/components/rule.md @@ -140,7 +140,7 @@ In case of Ruler in HA you need to make sure you have the following labelling se * Labels that need to be dropped just before sending to alermanager in order for alertmanager to deduplicate alerts e.g `--alert.label-drop="replica"`. -Full relabelling is planned to be done in future and is tracked here: https://github.com/improbable-eng/thanos/issues/660 +Full relabelling is planned to be done in future and is tracked here: https://github.com/thanos-io/thanos/issues/660 ## Flags diff --git a/docs/getting-started.md b/docs/getting-started.md index 652e080f4c..8ef0047bda 100644 --- a/docs/getting-started.md +++ b/docs/getting-started.md @@ -27,7 +27,7 @@ Thanos will work in cloud native environments as well as more traditional ones. ## Get Thanos! -You can find the latest Thanos release [here](https://github.com/improbable-eng/thanos/releases). +You can find the latest Thanos release [here](https://github.com/thanos-io/thanos/releases). If you want to build Thanos from source you would need a working installation of the Go [toolchain](https://github.com/golang/tools) (`GOPATH`, `PATH=${GOPATH}/bin:${PATH}`). @@ -35,8 +35,8 @@ If you want to build Thanos from source you would need a working installation of Thanos can be downloaded and built by running: ```bash -go get -d github.com/improbable-eng/thanos/... -cd ${GOPATH}/src/github.com/improbable-eng/thanos +go get -d github.com/thanos-io/thanos/... +cd ${GOPATH}/src/github.com/thanos-io/thanos make ``` diff --git a/docs/integrations.md b/docs/integrations.md index ddfcb9f365..862c949979 100644 --- a/docs/integrations.md +++ b/docs/integrations.md @@ -9,7 +9,7 @@ slug: /integrations.md ## StoreAPI -[StoreAPI](https://github.com/improbable-eng/thanos/blob/master/pkg/store/storepb/rpc.proto) is a common proto interface for gRPC component that can connect to [Querier](components/query.md) in order to fetch the metric series. Natively Thanos implements [Sidecar](components/sidecar.md) (local Prometheus data), [Ruler](components/rule.md) and [Store gateway](components/store.md). This solves fetching series from Prometheus or Prometheus TSDB format, however same interface can be used to fetch metrics from other storages. +[StoreAPI](https://github.com/thanos-io/thanos/blob/master/pkg/store/storepb/rpc.proto) is a common proto interface for gRPC component that can connect to [Querier](components/query.md) in order to fetch the metric series. Natively Thanos implements [Sidecar](components/sidecar.md) (local Prometheus data), [Ruler](components/rule.md) and [Store gateway](components/store.md). This solves fetching series from Prometheus or Prometheus TSDB format, however same interface can be used to fetch metrics from other storages. Below you can find some public integrations with other systems through StoreAPI: diff --git a/docs/proposals/approved/201901-read-write-operations-bucket.md b/docs/proposals/approved/201901-read-write-operations-bucket.md index 03871ea69a..3c2a8c6050 100644 --- a/docs/proposals/approved/201901-read-write-operations-bucket.md +++ b/docs/proposals/approved/201901-read-write-operations-bucket.md @@ -8,10 +8,10 @@ owner: bwplotka ### Tickets: -* https://github.com/improbable-eng/thanos/issues/298 (eventual consistency) -* https://github.com/improbable-eng/thanos/issues/377 (eventual consistency & partial upload) -* https://github.com/improbable-eng/thanos/issues/564 (retention vs store gateway) -* https://github.com/improbable-eng/thanos/issues/271 (adapt for removals faster) +* https://github.com/thanos-io/thanos/issues/298 (eventual consistency) +* https://github.com/thanos-io/thanos/issues/377 (eventual consistency & partial upload) +* https://github.com/thanos-io/thanos/issues/564 (retention vs store gateway) +* https://github.com/thanos-io/thanos/issues/271 (adapt for removals faster) ## Summary @@ -36,7 +36,7 @@ in Thanos system, like: * Thanos compactor uploads compacted block and deletes source blocks. After next sync iteration it does not see a new block (read after write eventual consistency). It sees gap, wrongly plans next compaction and causes non-resolvable overlap. * Thanos compactor uploads compacted block and deletes source blocks. Thanos Store Gateway syncs every 3m so it missed that fact. Next query that hits store gateway tries to fetch deleted source blocks and fails. -Currently, we have only basic safeguards against those in form of [`syncDelay`](https://github.com/improbable-eng/thanos/blob/bc088285a1b4bf464fdf2539e4b365b805874eed/pkg/compact/compact.go#L187). +Currently, we have only basic safeguards against those in form of [`syncDelay`](https://github.com/thanos-io/thanos/blob/bc088285a1b4bf464fdf2539e4b365b805874eed/pkg/compact/compact.go#L187). That helps with operations between sidecar and compactor but does not fix inter-compactor logic in case of eventual consistent storage or partial upload failures. We also partially assumed strong consistency for object storage, because [GCS has strong consistency](https://cloud.google.com/storage/docs/consistency) and S3 has it as well, diff --git a/docs/proposals/completed/201809_gossip-removal.md b/docs/proposals/completed/201809_gossip-removal.md index 725a2d081c..3e7d84e312 100644 --- a/docs/proposals/completed/201809_gossip-removal.md +++ b/docs/proposals/completed/201809_gossip-removal.md @@ -6,12 +6,12 @@ status: completed owner: bwplotka --- -### Ticket: https://github.com/improbable-eng/thanos/issues/484 +### Ticket: https://github.com/thanos-io/thanos/issues/484 ## Summary It is becoming clear that we need to remove gossip protocol as our main way of communication between Thanos Querier and other components. Static configuration seems to be well enough for our simple use cases. To give users more flexibility -(similar to gossip auto-join logic), we already wanted to introduce a [File SD](https://github.com/improbable-eng/thanos/issues/492) +(similar to gossip auto-join logic), we already wanted to introduce a [File SD](https://github.com/thanos-io/thanos/issues/492) that allows changing `StoreAPI`s on-the-fly. ## Motivation @@ -40,9 +40,9 @@ custom app level protocol. This is a no-go if you use L7 loadbalancers and proxi we needed to implement health check and metadata propagation anyway. In fact, `StoreAPI.Info` was already there all the time. * Gossip operates per `peer` level and there is no way you can abstract multiple peers behind loadbalancer. This hides easy solutions from our eyes, e.g how to make Store Gateway HA. Without gossip, you can just use Kubernetes HA Service or any other loadbalancer. -To support Store Gateway HA for gossip we would end up implementing LB logic in Thanos Querier (like proposed [here](https://github.com/improbable-eng/thanos/pull/404)) +To support Store Gateway HA for gossip we would end up implementing LB logic in Thanos Querier (like proposed [here](https://github.com/thanos-io/thanos/pull/404)) * At some point we want to be flexible and allow other discovery mechanisms. Gossip does not work for everyone and static flags -are too.. static. (: We need [File SD](https://github.com/improbable-eng/thanos/issues/492) for flexibility anyway. +are too.. static. (: We need [File SD](https://github.com/thanos-io/thanos/issues/492) for flexibility anyway. * One thing less to maintain. ## Goals @@ -50,14 +50,14 @@ are too.. static. (: We need [File SD](https://github.com/improbable-eng/thanos/ * Remove gossip support from code (Decision after initial feedback) * We are still RC, so technically there are no API guarantees yet. * Leave --store flags -* Make sure [File SD](https://github.com/improbable-eng/thanos/issues/492) is in place and documented before removal. +* Make sure [File SD](https://github.com/thanos-io/thanos/issues/492) is in place and documented before removal. ## Proposal: Steps -* Add File Service Discovery (SD): https://github.com/improbable-eng/thanos/issues/492 +* Add File Service Discovery (SD): https://github.com/thanos-io/thanos/issues/492 * Remove gossip from the documentation, be clear what talks with what (!) * Deprecate gossip in code. -* Remove gossip code and flags AFTER [File SD](https://github.com/improbable-eng/thanos/issues/492) is done and stable. +* Remove gossip code and flags AFTER [File SD](https://github.com/thanos-io/thanos/issues/492) is done and stable. ### Backwards compatibility diff --git a/docs/proposals/rejected/config.md b/docs/proposals/rejected/config.md index 7b2175d199..17011f283c 100644 --- a/docs/proposals/rejected/config.md +++ b/docs/proposals/rejected/config.md @@ -12,7 +12,7 @@ The proposal of creating a central configuration component within Thanos has bee Cluster configuration for targets will be implemented in a separate repository and we may look at open sourcing in the future if there are others that have the same needs. -Please see [Issue 387](https://github.com/improbable-eng/thanos/pull/387) and [Prometheus/Prometheus - Issue 4309](https://github.com/prometheus/prometheus/issues/4309) for more information. +Please see [Issue 387](https://github.com/thanos-io/thanos/pull/387) and [Prometheus/Prometheus - Issue 4309](https://github.com/prometheus/prometheus/issues/4309) for more information. ## Motivation diff --git a/pkg/block/index.go b/pkg/block/index.go index 1354c91d5a..c8ce38272f 100644 --- a/pkg/block/index.go +++ b/pkg/block/index.go @@ -446,7 +446,7 @@ type ignoreFnType func(mint, maxt int64, prev *chunks.Meta, curr *chunks.Meta) ( // - all "complete" outsiders (they will not accessed anyway) // - removes all near "complete" outside chunks introduced by https://github.com/prometheus/tsdb/issues/347. // Fixable inconsistencies are resolved in the new block. -// TODO(bplotka): https://github.com/improbable-eng/thanos/issues/378 +// TODO(bplotka): https://github.com/thanos-io/thanos/issues/378 func Repair(logger log.Logger, dir string, id ulid.ULID, source metadata.SourceType, ignoreChkFns ...ignoreFnType) (resid ulid.ULID, err error) { if len(ignoreChkFns) == 0 { return resid, errors.New("no ignore chunk function specified") diff --git a/pkg/ui/templates/bucket.html b/pkg/ui/templates/bucket.html index 88031f4fc6..98825e71e9 100644 --- a/pkg/ui/templates/bucket.html +++ b/pkg/ui/templates/bucket.html @@ -23,7 +23,7 @@ diff --git a/pkg/ui/templates/rule_menu.html b/pkg/ui/templates/rule_menu.html index df4cbfbb95..77db75b303 100644 --- a/pkg/ui/templates/rule_menu.html +++ b/pkg/ui/templates/rule_menu.html @@ -10,7 +10,7 @@