Combine GatherNoCompactionMarkFilter and GatherNoDownsampleMark to prevent code duplication

[RohitKochhar]

Is your proposal related to a problem?

With the addition of the no-downsample-mark.json block marker, some logic was retooled from the process to mark a block for no compaction. From this, some duplication has been introduced that should be fixed for clarity and better conformity.

Describe the solution you'd like

I would like to open a PR to change the implemented logic for marking a block no-downsample to minimize code duplication.

Describe alternatives you've considered

N/A

Additional context

To keep the scopes of the PRs focused, I think it is best that the first PR implementing the no-downsample logic (#5945) is accepted and merged into master before I open a new PR for this.

cc: @fpetkovski

[nikzayn]

Can you please assign me this, I'd like to work on it. Thanks!!

[nikzayn]

hey @RohitKochhar can you please brief me about the syntax and what needs to be done here?

[RohitKochhar]

Hey @nikzayn, sorry that it took so long for me to see your comment here.

Basically, you'll see that the implementation for the two filters (one for NoCompact and one for NoDownsample) are quite similar. It would be ideal if the logic for the two were combined so that there was minimal code duplication.

[jatinagwal]

Hey @RohitKochhar, we have to reuse the filter function ?

[RohitKochhar]

Which specific filter function are you referring to?

[jatinagwal]

function named Filter in this which has the filtering logic.

[yeya24]

@jatinagwal I don't think there is a strict requirement to use the same function here. The goal is to keep the core filter logic in one place and you can extend it or get it working for different markers.

[jatinagwal]

Sorry, for late response. I was stuck in the execution.
My first approach was to make seperate Filter method and then call that wherever needed, but, it have so many attributes and is calling other functions like gathernodownsample struct, nodownsamplemarkedblock func etc. So, we have to create these attributes and function for standard Filter method that we are writing.
So, I tried with creating a new function for this part .
Can you please guide like with which approach should I go? Or what other solution do you think we can implement?