Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query Frontend: lookback_delta is not part of the cache key #5847

Closed
yeya24 opened this issue Nov 2, 2022 · 0 comments · Fixed by #5854
Closed

Query Frontend: lookback_delta is not part of the cache key #5847

yeya24 opened this issue Nov 2, 2022 · 0 comments · Fixed by #5854

Comments

@yeya24
Copy link
Contributor

yeya24 commented Nov 2, 2022

There is a query param lookback_delta which allows us to overwrite the lookback delta value from the engine.

However, this is not part of the query frontend cache key so if lookback_delta is set differently in a range query, the wrong cached value would be selected.

Current cache key can be found here https://github.com/thanos-io/thanos/blob/main/pkg/queryfrontend/cache.go#L36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant