Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compactor: add concurrent downsampling #4363

Closed
GiedriusS opened this issue Jun 22, 2021 · 2 comments · Fixed by #4430
Closed

compactor: add concurrent downsampling #4363

GiedriusS opened this issue Jun 22, 2021 · 2 comments · Fixed by #4430
Labels
component: compact difficulty: easy feature request/improvement

Comments

@GiedriusS
Copy link
Member

Is your proposal related to a problem?

It kind of is, downsampling isn't the fastest.

Describe the solution you'd like

A flag such as --downsample.concurrency= on Thanos Compact. Then, a specified number of would-be downsampled concurrently.

Describe alternatives you've considered

Running multiple Thanos Compact instances working on different external labels but it's a pain to set up and maintain.

Additional context

N/A
@akhill10
Copy link

akhill10 commented Jul 5, 2021

hey @GiedriusS , I am new to this repo as it's labeled easy can I take this up ? It would be great if you can guide me through this.

@yeya24
Copy link
Contributor

yeya24 commented Jul 6, 2021 •
edited
Loading

I will take this one as we need this feature for compaction performance.

@yeya24 yeya24 mentioned this issue Jul 9, 2021
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: compact difficulty: easy feature request/improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for downsampling concurrency yeya24/thanos
3 participants
@GiedriusS @akhill10 @yeya24