Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For each write to Thanos/receive, add limit to the allowed number of samples #3964

Closed
spaparaju opened this issue Mar 24, 2021 · 7 comments
Closed
Labels

Comments

@spaparaju
Copy link
Contributor

spaparaju commented Mar 24, 2021

Is your proposal related to a problem?

Yes

Currently Thanos based hosted monitoring services lack protection to limit the number of samples that can be accepted at 'Thanos receive' component.

Describe the solution you'd like

For each write call, define a configurable upper bound (at Thanos receive component) to the number of samples that can be received.

Describe alternatives you've considered

None

Additional context

PR for this proposal : #3963

@spaparaju spaparaju changed the title add per-each-write limit to the allowed number of samples For each write to Thanos/receive, add limit to the allowed number of samples Mar 24, 2021
@metalmatze
Copy link
Contributor

I'm wondering if that should be really part of the Thanos Receiver and not some other proxy in front of the Receiver.
Maybe it still fits into the Receiver Route once the Receiver is split into Receiver and Receiver Route?

@stale
Copy link

stale bot commented Jun 2, 2021

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

@stale stale bot added the stale label Jun 2, 2021
@spaparaju
Copy link
Contributor Author

The idea behind this knob is to protect, configure resources at Receiver pods

@stale stale bot removed the stale label Jun 2, 2021
@stale
Copy link

stale bot commented Aug 2, 2021

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

@stale stale bot added the stale label Aug 2, 2021
@stale
Copy link

stale bot commented Aug 17, 2021

Closing for now as promised, let us know if you need this to be reopened! 🤗

@stale stale bot closed this as completed Aug 17, 2021
@bill3tt
Copy link
Contributor

bill3tt commented Aug 18, 2021

still relevant

1 similar comment
@spaparaju
Copy link
Contributor Author

still relevant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants