Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store: Add LRU caching for posting offset / adaptive postingOffsetInMemSampling based on traffic #2395

Closed
bwplotka opened this issue Apr 8, 2020 · 2 comments

Comments

@bwplotka
Copy link
Member

bwplotka commented Apr 8, 2020

After we fixed postingOffset sampling which was broken (we were keeping in memory all of them, instead of 1/32 as we intended), some of the users see extreme improvement:

image

This means that the about of postings is extreme in some setups, so what we keep in memory in terms of posting offsets really matters. This means we might need some caching for posting offsets as well. While we store them on disk, still disk lookup might be slower than in memory. I doubt there would be a benefit to storing this in remote cache though.

cc @d-ulyanov @mkabischev

@stale
Copy link

stale bot commented May 8, 2020

Hello 👋 Looks like there was no activity on this issue for last 30 days.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity for next week, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

@stale stale bot added the stale label May 8, 2020
@bwplotka
Copy link
Member Author

This needs like some very advanced logic, which is not needed, yet. Closing for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant