Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Summary quantiles are not exposed anymore for certain metrics in thanos-query #1543

Closed
bandesz opened this issue Sep 19, 2019 · 5 comments
Closed

Comments

@bandesz
Copy link
Contributor

bandesz commented Sep 19, 2019

Thanos, Prometheus and Golang version used

Thanos version: 0.6.1
Prometheus version: 2.6.1

What happened

prometheus_engine_query_duration_seconds isn't exposed anymore with the {app="thanos-query"} label. (examples/grafana/thanos-query.json refers to this).

Was this metric removed? (I couldn't find anything relevant in the changelogs.)
Can this be a problem of the Prometheus+Thanos version combo we're using?

Edit: The following metrics doesn't have the quantiles reported anymore:

  • prometheus_engine_query_duration_seconds
  • http_request_size_bytes
  • http_response_size_bytes
@bwplotka
Copy link
Member

Hm. I can see it being exposed on our services as summary. Maybe no query was triggered against this Querier that's why?

I can see prometheus_engine_query_duration_seconds_count and prometheus_engine_query_duration_seconds_sum

@GiedriusS
Copy link
Member

Indeed, I see those metrics on 0.7.0. Perhaps you need to run at least one query like @bwplotka says.

@bandesz
Copy link
Contributor Author

bandesz commented Oct 2, 2019

I still see prometheus_engine_query_duration_seconds_count and prometheus_engine_query_duration_seconds_sum but previously we had the quantiles, e.g.:

prometheus_engine_query_duration_seconds{quantile="0.99",slice="result_sort"}

Where did that go?

@bandesz
Copy link
Contributor Author

bandesz commented Oct 2, 2019

I think this might be caused by #1314 or a similar change.

The following metrics also doesn't have the quantiles reported anymore: http_request_size_bytes and http_response_size_bytes.

@bandesz bandesz changed the title prometheus_engine_query_duration_seconds not being reported for thanos-query Summary quantiles are not exposed anymore for certain metrics in thanos-query Oct 2, 2019
@stale
Copy link

stale bot commented Jan 11, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 11, 2020
@stale stale bot closed this as completed Jan 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants