Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

store: Selector labels from store #1034

Closed
bwplotka opened this issue Apr 15, 2019 · 2 comments
Closed

store: Selector labels from store #1034

bwplotka opened this issue Apr 15, 2019 · 2 comments
Labels
component: store difficulty: medium feature request/improvement help wanted priority: P1

Comments

@bwplotka
Copy link
Member

AC:

  • Store gateway has selector labels similar as Querier has (--selector) which allows to specify some labels that will part of Announced labels (through Info) but will be manually specified.
  • Document this feature better.

Why?

This will make Store GW smart sharding better. So we can have kind of external labels querier can use for initial filtering. Problem right now is that it's not easy for store to deduce those labels from the storage as it changes frequently. Same issue is for federated Querier, although for Querier adding such logic (propagate all announced labels from underlying StoreAPIs might be bit easier)

cc @devnev @domgreen
@jojohappy jojohappy mentioned this issue Apr 19, 2019
Closed
@bwplotka
Copy link
Member Author

bwplotka commented Sep 7, 2019

#1501

@bwplotka
Copy link
Member Author

We can now shard Store Gateway. The stable version of this should be released with v0.9.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: store difficulty: medium feature request/improvement help wanted priority: P1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bwplotka