From 8cf5e85a79c207106db96183fff4d78a7628dbd7 Mon Sep 17 00:00:00 2001 From: John Belmonte Date: Wed, 15 Jul 2020 15:59:33 +0900 Subject: [PATCH] fix increment of thanos_compact_downsample_total counter (#2895) `thanos_compact_downsample_total` metric was not incremented for ResLevel1 Signed-off-by: John Belmonte --- CHANGELOG.md | 3 ++- cmd/thanos/downsample.go | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index c8a737ca62..f287817ccc 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -16,7 +16,8 @@ We use *breaking* word for marking changes that are not backward compatible (rel - [#2665](https://github.com/thanos-io/thanos/pull/2665) Swift: fix issue with missing Content-Type HTTP headers. - [#2800](https://github.com/thanos-io/thanos/pull/2800) Query: Fix handling of `--web.external-prefix` and `--web.route-prefix` - [#2834](https://github.com/thanos-io/thanos/pull/2834) Query: Fix rendered JSON state value for rules and alerts should be in lowercase -- [#2866](https://github.com/thanos-io/thanos/pull/2866) Receive, Querier: Fixed leaks on receive and qwuerier Store API Series, which were leaking on errors. +- [#2866](https://github.com/thanos-io/thanos/pull/2866) Receive, Querier: Fixed leaks on receive and querier Store API Series, which were leaking on errors. +- [#2895](https://github.com/thanos-io/thanos/pull/2895) Compact: Fix increment of `thanos_compact_downsample_total` metric for downsample of 5m resolution blocks. ### Added diff --git a/cmd/thanos/downsample.go b/cmd/thanos/downsample.go index 046855d508..e3d027746e 100644 --- a/cmd/thanos/downsample.go +++ b/cmd/thanos/downsample.go @@ -234,7 +234,7 @@ func downsampleBucket( metrics.downsampleFailures.WithLabelValues(compact.DefaultGroupKey(m.Thanos)) return errors.Wrap(err, "downsampling to 60 min") } - metrics.downsamples.WithLabelValues(compact.DefaultGroupKey(m.Thanos)) + metrics.downsamples.WithLabelValues(compact.DefaultGroupKey(m.Thanos)).Inc() } } return nil