Don't let validators override values already set in the schema #911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 98.70% // Head: 98.70% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #911 +/- ##
=======================================
Coverage 98.70% 98.70%
=======================================
Files 68 68
Lines 7964 7976 +12
=======================================
+ Hits 7861 7873 +12
Misses 103 103
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
tfranzel
added a commit
that referenced
this pull request
Mar 4, 2023
* fix non-functional test from #911 * Fix linting error * Test that @extend_schema_field is working for custom URLFields * Don't override schema validators in case they are already set Co-authored-by: ruben <ruben.simons@web.de> Co-authored-by: T. Franzel <tfranzel@users.noreply.github.com>
|
merged by adb6a8e sry this took a while. Your change is nice, but you tests were utterly useless. 😆
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This at least resolves the bug that I encountered in the workaround for this issue.
I have included a test case that validates that
@extend_schema_fieldis working for custom URLFields, which it was not previously