Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for DRF >= 3.14.0 #865

Closed
ghost opened this issue Nov 22, 2022 · 6 comments
Closed

Add support for DRF >= 3.14.0 #865

ghost opened this issue Nov 22, 2022 · 6 comments

Comments

@ghost
Copy link

ghost commented Nov 22, 2022

NullBooleanField was removed in DRF 3.14.0 which affect drf-spectacular ( see PR ). The latest drf-spectacular, or any previous releases for that matter are incompatible with DRF>=3.14.0. More specifically, drf-spectacular should stop using NullBooleanField as it's been deprecated in DRF>=3.14.0 and start using BooleanField with allow_null=True.

I'm unaware wether there are further incompatibility issues with DRF >= 3.14.0 besides NullBooleanField.

@tfranzel
Copy link
Owner

Hi, this is a duplicate of #816 and was fixed with #818

Please check your spectacular version. Beginning with 0.24.1 (current 0.24.2) we do support DRF>=3.14.0

@tfranzel
Copy link
Owner

drf-spectacular should stop using NullBooleanField

Unfortunately it is not that easy as we need to support Django REST Framework (3.10.3, 3.11, 3.12, 3.13, 3.14). We do keep supporting it where it is available.

@ghost
Copy link
Author

ghost commented Nov 22, 2022

@tfranzel thanks will close. I am concerned now with dependency resolution. I had run poetry update, which bumped drf to 3.14, but drf-spectacular was not bumped to 0.24.x.

Is this something I should report somewhere else?

@tfranzel
Copy link
Owner

tfranzel commented Nov 22, 2022

that is not an issue on our side. poetry update will not update to the newest version like that. I think it will update Z in X.Y.Z. Definitely not X. Unsure about Y from the top of my head. This has bitten me before too.

This is general thing to keep in mind when dealing with poetry

@ghost
Copy link
Author

ghost commented Nov 22, 2022

Got it! Appreciate the quick response. Keep up the good work 😄

@ghost ghost closed this as not planned Won't fix, can't repro, duplicate, stale Nov 22, 2022
@tfranzel
Copy link
Owner

also there was some issue with stale local poetry caches, which they fixed in newer versions i think. This led to not even Z updates being used.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant