Making enum override hash generation match when blank or None values included. #833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 98.68% // Head: 98.70% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #833 +/- ##
==========================================
+ Coverage 98.68% 98.70% +0.02%
==========================================
Files 66 66
Lines 7617 7659 +42
==========================================
+ Hits 7517 7560 +43
+ Misses 100 99 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
…ash to match the hash generation logic in the enum post processor hook
trumpet2012
force-pushed
the
blank-enum-hashing
branch
from
4c12293
to
43a8d61
Compare
|
Just pushed a fix for a Django compatibility issue in the new tests. |
|
thx @trumpet2012. Sry this took so long. Excellent PR! I just simplified the the |
tfranzel
added a commit
that referenced
this pull request
Dec 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #832.
This updates the logic in
load_enum_name_overridesso that it creates the hash value after removing None and blank string values to match the same hashing behavior found inpostprocess_schema_enums.Without this the overrides aren't correctly applied since the hashes don't match.