Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use custom Lotus image, HotStore renaming, and misc #232

Merged
merged 7 commits into from
Apr 9, 2020
Merged

Conversation

jsign
Copy link
Contributor

@jsign jsign commented Apr 7, 2020

This PR:

@jsign jsign added this to the Sprint 34 milestone Apr 7, 2020
@jsign jsign self-assigned this Apr 7, 2020
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
image: textile/lotus:latest
image: textile/lotus:custom
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tag now is custom since I'll have to wait our merged-PR makes its way to interopnet branch. This happens regularly when interopnet catchup changes of testnet/3.
When that happens, I can use an automatic image that gets generated by us in this repo.

That custom tag is basically a image generated by me under that automatic-build setup with the necessary changes. So will eventually target the one generated automatically.

volumes:
- textile-fc-lotus:/data
ports:
- 1234:1234
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See textileio/lotus-build repo Readme, but it's basically using a reverse proxy to connect to Lotus since the API is hardcoded to listen on localhost, so can't be accessed from outside.

Comment on lines +12 to +13
"/dns4/t01000.miner.interopnet.kittyhawk.wtf/tcp/1347/p2p/12D3KooWGzxzKZYveHXtpG6AsrUJBcWxHBFS2HsEoGTxrMLvKXtf",
"/ip4/52.36.61.156/tcp/1347/p2p/12D3KooWFETiESTf1v4PGUvtnxMAcEFMzLZbJGg4tjWfGEimYior",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interop bootstrap miners to connect to DHT.

Comment on lines +91 to +92
// Store stores a Cid in the HotStorage. At the IPFS level, it also mark the Cid as pinned.
func (ci *CoreIpfs) Store(ctx context.Context, c cid.Cid) (int, error) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsign jsign marked this pull request as ready for review April 9, 2020 12:26
@jsign jsign requested review from sanderpick and asutula April 9, 2020 12:26
Copy link
Member

@sanderpick sanderpick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jsign jsign merged commit 5b71b3b into master Apr 9, 2020
@jsign jsign deleted the jsign/pg7 branch April 9, 2020 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HotStorage: Rename Pin to Store
3 participants