Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standard os package test for Go 1.23rc1 is failing on Windows #2280

Closed
mathetake opened this issue Jul 5, 2024 · 3 comments
Closed

Standard os package test for Go 1.23rc1 is failing on Windows #2280

mathetake opened this issue Jul 5, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@mathetake
Copy link
Member

This is a blocker for the next wazero release
https://github.com/tetratelabs/wazero/actions/runs/9767159219/job/26961798739?pr=2277

@mathetake mathetake added the bug Something isn't working label Jul 5, 2024
@mathetake mathetake changed the title BenchmarkWasip1/Run/src_os.test for Go 1.23rc1 is failing on Windows Standard os package test for Go 1.23rc1 is failing on Windows Jul 5, 2024
@evacchi
Copy link
Contributor

evacchi commented Jul 7, 2024

so it looks like this is -- big surprise -- an issue with FS handling. TestCopyFS is the failing test, and you can see it does some special handling in the case of Windows, which means that the FS abstraction is leaky:

https://github.com/golang/go/blob/release-branch.go1.23/src/os/os_test.go#L3372-L3445

This is not the first case when we skip a test on Windows, so I think we can skip this test here

https://github.com/tetratelabs/wazero/blob/main/internal/integration_test/stdlibs/bench_test.go#L103-L107

				args = append(args,
					"-test.skip=TestRenameCaseDifference/dir|"+
						"TestDirFSPathsValid|TestDirFS|TestDevNullFile|"+
-						"TestOpenError|TestSymlinkWithTrailingSlash")
+						"TestOpenError|TestSymlinkWithTrailingSlash|TestCopyFS")

this makes all the rest of the suite pass; see this test run on my branch https://github.com/evacchi/wazero/actions/runs/9827533698/job/27130327321?pr=57

@mathetake
Copy link
Member Author

Good catch Edo!

@evacchi
Copy link
Contributor

evacchi commented Jul 7, 2024

I still got it 😎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants