Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for bottom position #234

Closed
timnlupo opened this issue Oct 28, 2020 · 7 comments
Closed

Add support for bottom position #234

timnlupo opened this issue Oct 28, 2020 · 7 comments
Assignees

Comments

@timnlupo
Copy link

Hi all! I'm thinking about adding support for a position prop with options top or bottom. This would allow users to specify whether they want the notification to drop down from the top or pop up from the bottom. Similar to the functionality in this repo.

Please lmk what you think before I invest the time in building it out. Thanks.

@intechsol20
Copy link

Yes. I want that too.

@testshallpass
Copy link
Owner

testshallpass commented Dec 17, 2020

A position prop would be a nice convenient way. This though is currently supported by setting startDelta and endDelta to the window height (useWindowDimensions().height).

@timnlupo
Copy link
Author

I just tried this, you actually need to set

startDelta={useWindowDimensions().height}
endDelta={useWindowDimensions().height - height} // height is the height of the alert

Since height is saved in the DropdownAlert's state, I think it makes sense to add a position prop to be able to easily toggle it. Otherwise, a user has to add an onLayout to a view surrounding the DropdownAlert (which gets messy).

Going to work on this (should be pretty straightforward) and will update here.

@shawnFallon
Copy link

Are there any updates to this?

@testshallpass
Copy link
Owner

testshallpass commented Jul 31, 2023

I have simplified to a single animation flow from the top in latest release. That being said, I am open to support the inverse. I will take a look at the feasibility soon.

@testshallpass
Copy link
Owner

Update: implemented in PR #302

@testshallpass
Copy link
Owner

Completed in v5.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants