-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
separate input devices from pointer/keyboard API #1003
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 38e4cc4:
|
Codecov Report
@@ Coverage Diff @@
## main #1003 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 87 85 -2
Lines 1876 2058 +182
Branches 679 706 +27
==========================================
+ Hits 1876 2058 +182
Help us with your feedback. Take ten seconds to tell us how you rate us. |
🎉 This PR is included in version 14.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
What:
Extract the logic how input devices and user agent create events from the API that describes the interaction.
feat:
auxclick
eventsfix:
Control
onAltGraph
contextmenu
events withdetail: 0
PointerEvent.isPrimary
button
property on pointer events separately from legacy mouse eventsmousedown
andmouseup
happen on different elementsmouseover
,mouseenter
andmousemove
on disabled elementsmouse*
events perpointerdown
event handler*out
and*over
events when moving into / out of nested elements*enter
and*leave
events on ancestorsWhy:
Closes #1000
Closes #999
Closes #998
Closes #997
Closes #957
How:
These changes extract the
System
which is supposed to contain the state of input devices and the logic how the user agent handles their signals.This reduces complexity of the code by separating these concerns and eases comparing the implementation with specifications and observations in the browser.
Checklist: