Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: eslint error and rerender issue that wouldn't use props #110

Merged
merged 1 commit into from
Dec 23, 2020
Merged

fix: eslint error and rerender issue that wouldn't use props #110

merged 1 commit into from
Dec 23, 2020

Conversation

MirrorBytes
Copy link
Collaborator

Fixes #107

@MirrorBytes
Copy link
Collaborator Author

This will also fix #106

benmonro
benmonro approved these changes Dec 23, 2020
View reviewed changes
Copy link
Member

@benmonro benmonro left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@allcontributors please add @MirrorBytes for bugs and code

@benmonro
Copy link
Member

@allcontributors please add @MirrorBytes for bugs and code

@allcontributors allcontributors bot mentioned this pull request Dec 23, 2020
Merged
@allcontributors
Copy link
Contributor

@benmonro

I've put up a pull request to add @MirrorBytes! 🎉

@benmonro
Copy link
Member

@MirrorBytes looked like Travis isn't registering. Truth be told I don't have the cycles to maintain this project but if you're interested I can make you admin if you want to migrate it to give actions or whatever else..

@MirrorBytes
Copy link
Collaborator Author

@benmonro I can configure actions for it, sure.

@benmonro
Copy link
Member

benmonro commented Dec 23, 2020 via email

@benmonro benmonro merged commit f0d6b33 into testing-library:master Dec 23, 2020
@benmonro
Copy link
Member

🎉 This PR is included in version 3.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benmonro benmonro benmonro approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rerender issue
2 participants
@MirrorBytes @benmonro