Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Return type of unmount is void #857

Merged
merged 1 commit into from
Jan 7, 2021

Conversation

sanchit121
Copy link
Contributor

#856

Checklist:

  • Documentation added to the
    docs site N/A
  • Tests
  • Typescript definitions updated
  • Ready to be merged

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 7, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 35b3e61:

Sandbox Source
React Configuration
react-testing-library-examples Configuration

@codecov
Copy link

codecov bot commented Jan 7, 2021

Codecov Report

Merging #857 (35b3e61) into master (64a8b9c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #857   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          140       140           
  Branches        28        28           
=========================================
  Hits           140       140           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64a8b9c...35b3e61. Read the comment docs.

@eps1lon eps1lon changed the title Update return type of unmount fix: Return type of unmount is void Jan 7, 2021
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@eps1lon eps1lon merged commit 1389f09 into testing-library:master Jan 7, 2021
@eps1lon
Copy link
Member

eps1lon commented Jan 7, 2021

@all-contributors add @sanchit121 for bug, code

@allcontributors
Copy link
Contributor

@eps1lon

I've put up a pull request to add @sanchit121! 🎉

@eps1lon eps1lon linked an issue Jan 7, 2021 that may be closed by this pull request
@github-actions
Copy link

github-actions bot commented Jan 7, 2021

🎉 This PR is included in version 11.2.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sanchit121
Copy link
Contributor Author

sanchit121 commented Jan 7, 2021

Thank you so much @eps1lon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Return type of unmount function
2 participants