Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation to reflect setup when using the CRA version #242

Closed
gndelia opened this issue Oct 24, 2020 · 7 comments
Closed

Update documentation to reflect setup when using the CRA version #242

gndelia opened this issue Oct 24, 2020 · 7 comments
Labels
documentation Improvements or additions to documentation wontfix This will not be worked on

Comments

@gndelia
Copy link
Collaborator

gndelia commented Oct 24, 2020

Now that this plugin is part of CRA after this PR facebook/create-react-app#8963 we might want to add a mention to it in the docs. Currently, the docs state how to use this plugin standalone, but probably CRA is far popular to ignore it 😛 . Perhaps we could consider

  • If I was already using the plugin, what should I do to use the version that comes from CRA?
  • If I want to use it as part of CRA, what should I do? Perhaps it's just highlighting which steps could be skipped, or linking to the CRA docs where the steps are mentioned if any.
@gndelia gndelia added the documentation Improvements or additions to documentation label Oct 24, 2020
@Belco90
Copy link
Member

Belco90 commented Oct 25, 2020

Yeah, I have been thinking about it. I even checked other ESLint plugins already included in CRA and they don't mention anything, so not sure what to do.

I guess at least we can add a mention within "Installation" to clarify which major version is included in CRA and since when.

@gndelia
Copy link
Collaborator Author

gndelia commented Oct 25, 2020

yeah something simple should be enough, we don't have to go that fancy 😄

@stale
Copy link

stale bot commented Apr 11, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Apr 11, 2021
@Belco90
Copy link
Member

Belco90 commented Apr 12, 2021

I think we should add this now since CRA uses v4 and we have released v4.

I figured out how to upgrade the plugin to v4 in a CRA project using yarn (with selective dependency resolution), but I don't have any idea how to do this with npm.

Additionally, it would be nice to create a PR to upgrade the plugin in CRA. I think @MichaelDeBoey wanted to give it a try.

@stale stale bot removed the wontfix This will not be worked on label Apr 12, 2021
@MichaelDeBoey
Copy link
Member

Created a PR to add eslint-plugin-testing-library@^4.x to CRA: facebook/create-react-app#10817

@Belco90
Copy link
Member

Belco90 commented May 26, 2021

Any ideas about how to suggest updating the plugin to v4 in a CRA project using v3 when dependencies are managed with npm? The only thing I can think of is disabling CRA internal ESLint and reinstall ESLint + plugins directly in the project so the user has full control of it, but I would like to avoid this way.

@stale
Copy link

stale bot commented Jul 25, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Jul 25, 2021
@stale stale bot closed this as completed Aug 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants