fix(role-helpers): refine logRoles fn types #1249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naorpeled
force-pushed
the
feat/role-helpers/improve-types
branch
from
f5e969f
to
6d810dd
Compare
4 tasks
MatanBobi
changed the title
|
@all-contributors please add @naorpeled for code :) |
|
I've put up a pull request to add @naorpeled! 🎉 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Increased the TS coverage of the logRoles and prettyRoles functions in the role helpers file,
at the moment cases with
hidden = trueoption were not covered.Why:
To further understand the scope of #1201 I've added these defs, I think it's good to have them in the repo.
Checklist:
docs site