-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: stronger typing of inputs #473
Merged
timdeschryver
merged 11 commits into
testing-library:main
from
andreialecu:refactor-inputs
Aug 3, 2024
Merged
refactor: stronger typing of inputs #473
timdeschryver
merged 11 commits into
testing-library:main
from
andreialecu:refactor-inputs
Aug 3, 2024
+212
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreialecu
commented
Jul 29, 2024
andreialecu
commented
Jul 29, 2024
andreialecu
commented
Jul 29, 2024
timdeschryver
approved these changes
Aug 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your time and great work on this @andreialecu !
@all-contributors please add @andreialecu for code, ideas, doc |
I've put up a pull request to add @andreialecu! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #464
This PR restores the type safety of inputs and introduces a new property called
inputs
and deprecatescomponentInputs
. Previously we had an union with{ [alias: string]: unknown }
which would essentially act asany
.We add a branded type through which aliases can be explicitly supplied.
Usage: