feat: Added initialRoute parameter to avoid resolver issues with using a default route #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| it('allows initially rendering a specific route to avoid triggering a resolver for the default route', async () => { | ||
| const expectedRoute = 'correct-route'; |
There was a problem hiding this comment.
Could you rename this to the following please.
I do think it makes it intention clearer.
Suggested change
| const expectedRoute = 'correct-route'; | |
| const initialRoute = 'initial-route'; |
|
|
||
| expect(resolver.isResolved).toBe(false); | ||
| expect(screen.queryByText('Secondary Component')).not.toBeInTheDocument(); | ||
| expect(await screen.findByText('button')).toBeInTheDocument(); |
There was a problem hiding this comment.
There's no need to await here.
Suggested change
| expect(await screen.findByText('button')).toBeInTheDocument(); | |
| expect(screen.getByText('button')).toBeInTheDocument(); |
| await render(RouterFixtureComponent, { | ||
| initialRoute: expectedRoute, | ||
| routes, | ||
| detectChangesOnRender: false, |
There was a problem hiding this comment.
Is there a reason why detect changes is set to false?
Suggested change
| detectChangesOnRender: false, |
There was a problem hiding this comment.
Mainly just to isolate the test from any extra logic, but I can remove it since it doesn't add any value here
|
Just updated the tests based on your suggestions! |
timdeschryver
approved these changes
Feb 18, 2023
|
@all-contributors please add @JJosephttg for code, tests |
|
@JJosephttg already contributed before to code, test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the ability to specify an initial route to render with. As someone who wanted to use my original routes in my tests, I found that even though I do initial navigation without detecting changes in my tests using navigate, I would still run into issues where my resolver would get triggered despite the fact I was switching before detecting changes.
This allows navigation to happen before the location listener is set up so that you may perform an initial route navigation without causing any resolvers/guards to run and additionally having to specify await navigate(...) in your tests