feat: add provideMockWithValues #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a function to create a Mock provider where you can also pass in values to assign as properties or functions on the mock.
timdeschryver
approved these changes
Jul 15, 2021
There was a problem hiding this comment.
Oh great addition, thanks @michaelwestphal !
I also added a commit to this PR to fix some dependencies.
|
@all-contributors please add @michaelwestphal for code, tests |
|
I've put up a pull request to add @michaelwestphal! 🎉 |
|
🎉 This PR is included in version 10.10.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for this wonderful library!
I would love to add a function to create a Mock provider where you can also pass in values to assign as properties or functions on the mock as desired. As
createMockWithValuescomplimentscreateMock, this new function is intended to complimentprovideMock.Ironically to me the hardest part of this addition was trying to figure out a reasonable unit test 😄