Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make unit for startup timeout more obvious #437

Merged
merged 4 commits into from
Feb 14, 2023
Merged

make unit for startup timeout more obvious #437

merged 4 commits into from
Feb 14, 2023

Conversation

mdunisch
Copy link
Contributor

@mdunisch mdunisch commented Jan 6, 2023

there is no documentation in what unit the parameter for withStartupTimeout is. Thats why i made it more obvious buy:

  • adding a comment in the readme example
  • adding "Ms" to the Param-Name (so you see it in your IDE directly)

@cristianrgreco cristianrgreco added enhancement New feature or request patch Backward compatible bug fix labels Feb 9, 2023
@cristianrgreco
Copy link
Collaborator

Thanks for raising @mdunisch, would you mind also updating the variable name in the interface?

withStartupTimeout(startupTimeout: number): this;

@mdunisch
Copy link
Contributor Author

Thanks for raising @mdunisch, would you mind also updating the variable name in the interface?

withStartupTimeout(startupTimeout: number): this;

@cristianrgreco fixed!

@cristianrgreco cristianrgreco merged commit 5a033cd into testcontainers:master Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request patch Backward compatible bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants