Why does WithDockerfileDirectory() when called will look for the directory in bin/Debug/net...

[haridasnykiel]

Why does the following method WithDockerfileDirectory() called from the ImageFromDockerfileBuilder class look at the bin folder by default? I would of expected it to look at the relative path of the class it is being called from.

Also I think the docs around the build with dockerfile is a bit lacking as it took me a while to figure out how to build the image from a docker file.

Currently using version <PackageReference Include="Testcontainers" Version="2.1.0" />

[haridasnykiel]

Thanks in advance

[ChrisTTian667]

Did you find a solution?

Since a couple of hours, I'm trying hard to build a docker image from a relative path. With no success.

[HofmeisterAn]

@haridasnykiel

Why does the following method WithDockerfileDirectory() called from the ImageFromDockerfileBuilder class look at the bin folder by default?

The base path (current working directory) is the location of the executable (assembly). All kinds of configuration files are copied to the output directory (native support by MSBuild and dotnet), I think it is common. Even the access of the build output is much more straightforward.

I would of expected it to look at the relative path of the class it is being called from.

Why is that?

@ChrisTTian667

Since a couple of hours, I'm trying hard to build a docker image from a relative path. With no success.

Can you add a small example that you are trying to achieve?

[haridasnykiel]

Yea I understand that, but it is not common to copy the dockerfile to the executable directory. Therefore I think it would be good to have this point to the root of the project by default or the folder of the class where the call is made.

I would be happy to contribute to make this change?

[HofmeisterAn]

I would be happy to contribute to make this change?

That would be great. Do you have anything specific in mind? I was thinking about an overloaded method, maybe something like this:

public readonly struct CommonDirectoryPath
{
  // TODO: Detect common directory paths
  public static readonly CommonDirectoryPath GitRoot = new CommonDirectoryPath("");

  public static readonly CommonDirectoryPath ProjectRoot = new CommonDirectoryPath("");

  private CommonDirectoryPath(string directoryPath)
  {
    this.DirectoryPath = directoryPath;
  }

  public string DirectoryPath { get; }
}

[...]

public IImageFromDockerfileBuilder WithDockerfileDirectory(CommonDirectoryPath directoryPath, string dockerfileDirectory)
{
  return this.WithDockerfileDirectory(Path.Combine(directoryPath.DirectoryPath, dockerfileDirectory));
}

[ChrisTTian667]

@HofmeisterAn , i've a solution with 2 projects

Solution

• TestService.Api
  • SomeCode.cs
  • DockerFile
• TestService.Api.Tests
  • IntegrationTest.cs

From the IntegrationTest in TestService.Api.Tests i try to create the TestService Docker Image like

        var apiContainerImageBuilder = new ImageFromDockerfileBuilder()
            .WithName("testservice")
            .WithDeleteIfExists(true)
            .WithDockerfileDirectory("../../../../TestService.Api")
            .WithCleanUp(true);

        var apiContainerImage = await apiContainerImageBuilder.Build();

But this results in an InvalidOperationException saying Docker image testserice:latest has not been created. It seems to be a problem with the folder, but i don't get the problem here. I also tried to specify the DockerFile and the Path as an absolute path, but with the same result.

Can you lead me into the right direction?

[HofmeisterAn]

Can you lead me into the right direction?

It is Dockerfile not DockerFile (F is lowercase). Or use .WithDockerfile("DockerFile").

[ChrisTTian667]

It is Dockerfile not DockerFile (F is lowercase). Or use .WithDockerfile("DockerFile").

Sorry, it was just wrong in my description. It is called Dockerfile in the solution.

I've pushed the Sample project into a public repo here:
https://github.com/ChrisTTian667/TestContainersSample

[HofmeisterAn]

Remove line 18 in your .Dockerignore file (**/Dockerfile*). Testcontainers creates a tar file that contains all necessary files (it tars the base directory).

testcontainers-dotnet/src/Testcontainers/Clients/DockerImageOperations.cs

Line 113 in ced98a9

var dockerfileArchiveFilePath = dockerfileArchive.Tar();

**/Dockerfile* excludes the Dockerfile from the archive.

[ChrisTTian667]

Remove line 18 in your .Dockerignore file (**/Dockerfile*). Testcontainers creates a tar file that contains all necessary files (it tars the base directory).

testcontainers-dotnet/src/Testcontainers/Clients/DockerImageOperations.cs

Line 113 in ced98a9

var dockerfileArchiveFilePath = dockerfileArchive.Tar();

**/Dockerfile* excludes the Dockerfile from the archive.

Thank you so much. This line costs me half a day. That works perfect :)

[HofmeisterAn]

Thank you so much. This line costs me half a day. That works perfect :)

You're welcome. Yeah, is not easy to discover. Unfortunately, the Docker remote API doesn't throw any error. We could check for mandatory files, though.

[haridasnykiel]

I have not yet had a think about it, ill look into it later today. Your solution looks good though ill give it a go. Also have not had a chance to properly look at the code base yet, so going to need sometime to familarise myself with it.

[haridasnykiel]

Sorry for the delay, been quite busy recently. So I have solution for this now, using the interface you suggested above. I want to test as a nuget package. How can I go creating the nuget package, its in the bin directory as I was expecting. I tried using the cake task, but getting an error:

Error: Could not reach target 'Create-NuGet-Packages' since it was skipped due to a criteria.

Never used cake before.

[HofmeisterAn]

The task is designed to run on CI/CD only. To bypass this change:

testcontainers-dotnet/build.cake

Line 133 in 96c7263

.WithCriteria(() => param.ShouldPublish)

to .WithCriteria(() => param.ShouldPublish || true).