Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Upgrade Testcontainers.Pulsar to use Apache Pulsar v4.0.0 #1291

Open
keshramjith opened this issue Nov 7, 2024 · 4 comments · May be fixed by #1294
Open

[Enhancement]: Upgrade Testcontainers.Pulsar to use Apache Pulsar v4.0.0 #1291

keshramjith opened this issue Nov 7, 2024 · 4 comments · May be fixed by #1294
Labels
enhancement New feature or request module An official Testcontainers module

Comments

@keshramjith
Copy link

Problem

Upgrade docker image of Testcontainers.Pulsar to Apache Pulsar v4.0.0

Solution

Changing docker image version and any other necessary changes required for Apache Pulsar v4.0.0

Benefit

Using the latest LTS version of Apache Pulsar

Alternatives

None

Would you like to help contributing this enhancement?

Yes

@keshramjith keshramjith added the enhancement New feature or request label Nov 7, 2024
@keshramjith
Copy link
Author

Please add the module label, I'm not sure how to do that

@HofmeisterAn
Copy link
Collaborator

Thanks for creating the issue. Do you know if any changes to the module are necessary? Could you simply override the default image instead? Typically, we try to avoid changing the default image version to prevent introducing breaking changes; instead, we recommend developers to pin the version.

@HofmeisterAn HofmeisterAn added the module An official Testcontainers module label Nov 7, 2024
@keshramjith
Copy link
Author

Yes, I did try overriding the image with .WithImage(), however I encountered a bunch of issues and some module changes are required.

@HofmeisterAn
Copy link
Collaborator

I see, thanks for the clarification. In this case, we usually make the necessary changes but try to support both configurations and ensure backward compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request module An official Testcontainers module
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants