Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WCOW Support #35

Closed
PSanetra opened this issue Feb 1, 2022 · 10 comments
Closed

WCOW Support #35

PSanetra opened this issue Feb 1, 2022 · 10 comments

Comments

@PSanetra
Copy link
Contributor

PSanetra commented Feb 1, 2022

It would be nice to support Ryuk in a windows container environment. Would you be open for such a contribution or do you consider this out-of-scope as the Java Testcontainers do not support WCOW at the moment?

It would be nice to have this for the dotnet-testcontainers project.

@kiview
Copy link
Member

kiview commented Jul 28, 2022

Hey @PSanetra, sorry for answering late.

I think this is a nice idea since a WCOW image of Ryuk would also help testcontainers-java in this regard (missing WCOW Ryuk is a blocker there as well).

We would be very happy if you could help in adding this support. How do you estimate the effort?

@gesellix
Copy link
Contributor

The PR #40 adds a Windows native layer to the existing multi-arch image.

@mdelapenya
Copy link
Member

Please see #40 (comment) for an update on this 🙏

@narcis-ro
Copy link

Hey guys. Are you still planning to merge either versions? Kind regards

@gesellix
Copy link
Contributor

gesellix commented Feb 22, 2024

-> #40 (comment)

@gesellix
Copy link
Contributor

A clean pull request is open for discussion at #110

@narcis-ro
Copy link

PR was merged. When is it gonna be released?

@gesellix
Copy link
Contributor

gesellix commented Mar 8, 2024

#120 ist more or less finished. I think after that some dependabot PRs might be merged, too, and then everything should be ready for a release.

@gesellix
Copy link
Contributor

gesellix commented Mar 9, 2024

Looks like a new release is available: https://github.com/testcontainers/moby-ryuk/releases/tag/0.7.0
:)

@mdelapenya
Copy link
Member

Indeed, let's reopen this issue in the case a bug in the windows container is found.

Thank you all for your patience 🙏🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants