You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We should consider simplifying the relationship between tesseract_visualization and tesseract_command_language such that tesseract_visualization does not need to know about specific implementations of the Instruction class. I think there are two options:
Eliminate the dependency of tesseract_visualization on the command language Instruction class completely.
Instead, the visualization base class could accept "standard" types for display (e.g. vector of poses, tesseract::JointTrajectory, etc.). We would then write conversions from specific types of instructions to these "standard" display types when necessary.
Create an over-ridable function to the Instruction class for producing a visualization, like:
virtualvoidcreateDisplay()
{
// Base implementation does nothing, but others can override if relevant
}
Pro: less changes need to be made to support this behavior
Con: Adding a function to a base class that is not relevant to every child class is a bit hacky and probably not great practice, even if that function is as simple as an empty void function
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
We should consider simplifying the relationship between
tesseract_visualization
andtesseract_command_language
such thattesseract_visualization
does not need to know about specific implementations of theInstruction
class. I think there are two options:tesseract_visualization
on the command languageInstruction
class completely.tesseract::JointTrajectory
, etc.). We would then write conversions from specific types of instructions to these "standard" display types when necessary.Instruction
class for producing a visualization, like:Beta Was this translation helpful? Give feedback.
All reactions