Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model S long range miss labeled as a 100D #4368

Closed
1 task done
VintageWillis opened this issue Nov 10, 2024 · 10 comments · Fixed by #4370
Closed
1 task done

Model S long range miss labeled as a 100D #4368

VintageWillis opened this issue Nov 10, 2024 · 10 comments · Fixed by #4370
Labels
enhancement New feature or request

Comments

@VintageWillis
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

What happened?

Very minor issue, the teslamate dashboard labels by Model S long range plus as a 100D. I know they are basically the same but it just doesn't line up with the Tesla naming from the car info and app.

image

image

I'm guessing this might also be the same with other raven Model Ss (long Range, Long Range Plus, Performance)

Expected Behavior

No response

Steps To Reproduce

No response

Relevant log output

NA

Screenshots

No response

Additional data

No response

Type of installation

Docker

Version

1.31.1

@cwanja
Copy link
Collaborator

cwanja commented Nov 10, 2024

Can you please query the Tesla API and get your 'vehicle_config' -> 'car_type'?

Follows #2193, #2454. Mimic PR #2455

@VintageWillis
Copy link
Author

"car_type":"models2"

@cwanja
Copy link
Collaborator

cwanja commented Nov 10, 2024

Thank you! Can you get your trim_badging as well? Assume 100D, but want to confirm.

@VintageWillis
Copy link
Author

You're correct ;)!
"trim_badging":"100d"

@cwanja
Copy link
Collaborator

cwanja commented Nov 10, 2024

Can you deploy #4370 and verify it is reporting correctly?

@VintageWillis
Copy link
Author

Can you deploy #4370 and verify it is reporting correctly?

I might need some help on how to, I'm using a Pi5 do I modify the compose.yml file to point to this new build?

@cwanja
Copy link
Collaborator

cwanja commented Nov 10, 2024

Can you deploy #4370 and verify it is reporting correctly?

I might need some help on how to, I'm using a Pi5 do I modify the compose.yml file to point to this new build?

https://docs.teslamate.org/docs/development#testing-with-our-ci-which-builds-the-docker-images-automatically-per-pr

To test the changes introduce by a PR you can edit your docker-compose.yml file as follows (replace pr-3836 with the PR number)

teslamate:
  # image: teslamate/teslamate:latest
  image: ghcr.io/teslamate-org/teslamate:pr-3836

@VintageWillis
Copy link
Author

Thanks , that works although the tooltip shows 100D when hovering over the model. But that might be expected?

image

@cwanja
Copy link
Collaborator

cwanja commented Nov 11, 2024

That is intended, as it is reporting the trim_badging from the Tesla API. For the "marketing name", we string together various variables and concatenate them for the display.

https://github.com/cwanja/teslamate/blob/3a5dfb8aca4a74a4f3f472bbd390a3d8e0ab9a71/lib/teslamate_web/live/car_live/summary.html.heex#

@JakobLichterfeld JakobLichterfeld added the enhancement New feature or request label Nov 11, 2024
@VintageWillis
Copy link
Author

Super happy with that great work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
3 participants