Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There is a 109-page "List of Nuclides" table in the API #1624

Closed
john-science opened this issue Jan 25, 2024 · 11 comments
Closed

There is a 109-page "List of Nuclides" table in the API #1624

john-science opened this issue Jan 25, 2024 · 11 comments
Assignees
Labels
cleanup Code/comment cleanup: Low Priority documentation Improvements or additions to documentation low priority Style points and non-features

Comments

@john-science
Copy link
Member

john-science commented Jan 25, 2024

In the ARMI docs, there is a full list of Nuclides table. When rendered to PDF it is about 109 pages long:

.. only:: html
.. _nuclide-bases-table:
.. exec::
import numpy

I think there are two possibilities:

  1. This isn't necessary in the docs: we can just remove the table.
  2. This is important data: we need to pull it out of the API and put it somewhere more findable in the docs.

Which of these is true?

@john-science john-science added documentation Improvements or additions to documentation cleanup Code/comment cleanup: Low Priority low priority Style points and non-features labels Jan 25, 2024
@john-science
Copy link
Member Author

john-science commented Jan 25, 2024

@ntouran @albeanth @drewj-usnctech @sombrereau @keckler I have given two options above. Which do YOU think is true?

(If no one votes, I will just decide.)

@albeanth
Copy link
Member

albeanth commented Jan 25, 2024

I vote 2 with an idea for the somewhere part:

  • Replacing it with a script that can generate it into a csv for Excel. If someone is really interested in it, doing something like that will very likely be more useful than a super long table.

That said, if option 1 is popular, I won't argue.

@jakehader
Copy link
Member

jakehader commented Jan 26, 2024

I think option 2 is correct, especially with half life data. I think the table is good in the document - if someone wants it in Excel or csv they can import ARMI and get it from the nuclide objects directly

109 pages seems extremely large though. Is the front pretty big or is the wrapping making the rows have larger heights?

@albeanth
Copy link
Member

@jakehader how about a compromise where we show a select number of nuclides and then reference the rest? E.g., show U238/225, some Zr, B10, C, H, Cs, Xe, etc, so the table is reasonably sized for the docs and then say something like "to see the remained X thousand nuclides, install ARMI and run this script."

Thoughts?

@keckler
Copy link
Member

keckler commented Jan 26, 2024

We don't explicitly list out cross section data in our docs, I don't see any reason why half life data should be any different.

My vote is for (1), this isn't necessary in the docs.

@john-science
Copy link
Member Author

We don't explicitly list out cross section data in our docs, I don't see any reason why half life data should be any different.

My vote is for (1), this isn't necessary in the docs.

Perhaps the real question is: Has anyone EVER used this table as a reference? No one has ever asked me about it, so I'm inclined to guess "no".

@jakehader
Copy link
Member

@jakehader how about a compromise where we show a select number of nuclides and then reference the rest? E.g., show U238/225, some Zr, B10, C, H, Cs, Xe, etc, so the table is reasonably sized for the docs and then say something like "to see the remained X thousand nuclides, install ARMI and run this script."

Thoughts?

I like this compromise, just listing the first 20 or something. It would be nice to document what nuclides are available in the docs, but if the script works and is maintained I don't see any issue with that.

If we had hard-coded cross section data that is imported/read in when someone configured ARMI or an application I think it should also be documented.

@jakehader
Copy link
Member

I am happy with this solution that @mgjarrett put together on #1634 since it will then render in HTML but not pollute the PDF.

@ntouran
Copy link
Member

ntouran commented Jan 30, 2024

I like the .. only:: html solution from #1634.

That said I don't find this particular table extremely useful. In a previous revision I believe it showed MCNP, MCC2, and MCC3 IDs rather than basic nuclide data, which made it a more valuable and meaningful cross-reference.

@john-science
Copy link
Member Author

john-science commented Feb 7, 2024

Votes thus far:

  • Option 1, remove the table:
    1. John
    2. Chris
    3. Nick
  • Option 2, move it to somewhere else in the docs:
    1. Tony
    2. Jake

@albeanth
Copy link
Member

albeanth commented Feb 7, 2024

To clarify my vote for 2: I don't think we should keep the table as is. That would be silly. It needs to be significantly trimmed. And if Option 1 is the winner, I won't argue.

@john-science john-science self-assigned this Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code/comment cleanup: Low Priority documentation Improvements or additions to documentation low priority Style points and non-features
Projects
None yet
Development

No branches or pull requests

5 participants